Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify --reuse and --rm flags #929

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

catthehacker
Copy link
Member

Signed-off-by: hackercat me@hackerc.at

@catthehacker catthehacker requested a review from a team as a code owner December 15, 2021 20:04
@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #929 (dfa8bbc) into master (0f04942) will increase coverage by 7.47%.
The diff coverage is 62.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   49.27%   56.74%   +7.47%     
==========================================
  Files          23       28       +5     
  Lines        2401     4159    +1758     
==========================================
+ Hits         1183     2360    +1177     
- Misses       1090     1592     +502     
- Partials      128      207      +79     
Impacted Files Coverage Δ
pkg/common/executor.go 46.90% <0.00%> (+2.03%) ⬆️
pkg/common/job_error.go 0.00% <0.00%> (ø)
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.53% <14.54%> (+3.60%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) ⬆️
pkg/container/docker_auth.go 45.00% <45.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad4bc8...dfa8bbc. Read the comment docs.

hackercat added 2 commits December 15, 2021 22:10
Signed-off-by: hackercat <me@hackerc.at>
Signed-off-by: hackercat <me@hackerc.at>
@mergify mergify bot removed the needs-work Extra attention is needed label Dec 15, 2021
@mergify mergify bot merged commit 4e0ba61 into nektos:master Dec 16, 2021
@catthehacker catthehacker deleted the cat/fix/better-help branch December 16, 2021 05:17
@catthehacker catthehacker linked an issue Dec 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Docker containers are always removed after a successful run
2 participants