fix: rework setupShellCommand #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catthehacker
force-pushed
the
cat/fix/run-step
branch
3 times, most recently
from
7a49419 to
b0766d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
==========================================
+ Coverage 49.27% 56.81% +7.54%
==========================================
Files 23 28 +5
Lines 2401 4161 +1760
==========================================
+ Hits 1183 2364 +1181
- Misses 1090 1590 +500
- Partials 128 207 +79
Continue to review full report at Codecov.
|
catthehacker
force-pushed
the
cat/fix/run-step
branch
from
b0766d6 to
e74b260
Compare
* move all logic to separate function so we can test that later * split `step.Shell` and `step.WorkingDirectory` setup into own funcs * general cleanup of function * use `ActPath` to not collide with checked out repository * use `shellquote.Split()` instead of `strings.Fields()` for better command split * replace single string concat with `fmt` Signed-off-by: hackercat <me@hackerc.at>
catthehacker
force-pushed
the
cat/fix/run-step
branch
from
e74b260 to
bd70028
Compare
Signed-off-by: hackercat <me@hackerc.at>
KnisterPeter
approved these changes
Dec 16, 2021
cplee
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step.Shellandstep.WorkingDirectorysetup into own funcsActPathto not collide with checked out repository (also avoids issues if path contains spaces)shellquote.Split()instead ofstrings.Fields()for better command splitfmtFixes #884
Fixes #865
Signed-off-by: hackercat me@hackerc.at