refactor: extract setupAction into ActionReader #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracts the functionality of reading an `action.y(a)ml` or creation of a `(Synthetic Action)` into its own type to enable better unit testing / mocking of those IO operations. This is done in preparation for the implementation of pre/post action support in act. Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
KnisterPeter
approved these changes
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 57.50% 58.18% +0.67%
==========================================
Files 32 34 +2
Lines 4594 4618 +24
==========================================
+ Hits 2642 2687 +45
+ Misses 1729 1706 -23
- Partials 223 225 +2
Continue to review full report at Codecov.
|
cplee
approved these changes
Feb 8, 2022
ChristopherHX
approved these changes
Feb 8, 2022
ZauberNerd
added a commit
to ZauberNerd/act
that referenced
this pull request
Feb 9, 2022
This commit cleans up a some naming nitpicks and interface errors that were introduced in nektos#986 * add `fileWriter` argument to `readAction` * do not export the `actionReader` interface * rename `actionyamlReader` to `actionYamlReader`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts the functionality of reading an
action.y(a)mlorcreation of a
(Synthetic Action)into its own type to enable betterunit testing / mocking of those IO operations.
This is done in preparation for the implementation of pre/post action
support in act.