feat: remove staff access in courses for catalog views #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
force-pushed
the
jlc/remove-staff-courses-home-page
branch
2 times, most recently
from
c9d46af
to
1fbf18c
Compare
johanseto
changed the title
andrey-canon
reviewed
Sep 9, 2024
| @@ -394,7 +394,6 @@ def can_see_in_catalog(): | |||
| """ | |||
| return ( | |||
| _has_catalog_visibility(courselike, CATALOG_VISIBILITY_CATALOG_AND_ABOUT) | |||
| or _has_staff_access_to_descriptor(user, courselike, courselike.id) | |||
There was a problem hiding this comment.
instead of removing this, could you add a feature flag inside the _has_staff_access_to_descriptor method that allows to keep standard and custom behavior ?
There was a problem hiding this comment.
Yes I could add a feature flag, but I only want to change can_see_in_catalog. I don't want to affect many other places where the staff could have permission.
Do you agree to add the feature flag only here?
andrey-canon
approved these changes
Sep 12, 2024
This is controversial, but simple. To do this in a monkey patch is a bigger task and also with more work. Is different due the change is in a nested function. Anyway the alternative is to monkeyPatch the _dispatch method and handle there. But its risky and also that method manage other permission with different ways.
This reverts commit 1fbf18c.
johanseto
force-pushed
the
jlc/remove-staff-courses-home-page
branch
from
7faf860
to
a29df93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is controversial, but simple. To do this in custom eox-nelp with a monkey patch is a bigger task and also with more work and risk. Is different due the change is in a nested function. Anyway the alternative is to monkeyPatch the
_dispatchmethod and handle there. But its risky and also that method manage other permission with different ways.Testing instructions
HIde a course in studio and check that for anonymous_user doesn't load but for staff general yes.
Before
staff
anonymous_user
After
staff
anonymous_user
Other information
Jira Story: