-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Symfony attribute describers #2112
Add Symfony attribute describers #2112
Conversation
You also fixed another issue (weird duplicated Models). That's cool ! There is only one remaining issue: |
Yup this is hopefully temporary, this was the fix for now. zircote/swagger-php#1528
Yup thats one of the things still on my 'todo' list. The other one is finding a way to prevent breaking the docs generation whenever |
@SBNTT Managed to fix everything + tests for all situations 😄 |
Yaay ! For months, we had a script that was postprocessing the generated OA specs using some ugly regexps, but you've fixed everything :) Thanks for your hard work @DjordyKoert ! |
Thanks a lot @DjordyKoert for this amazing PR, I hope to see it merged soon |
6135a63
to
a2f44ea
Compare
# Conflicts: # Tests/Functional/Controller/ApiController81.php # phpunit-baseline.json
Hi, I'm glad it was finally merged. #[MapRequestPayload(validationGroups: [EntityDTO::GROUP_CREATE])] EntityDTO $data and #[MapRequestPayload(validationGroups: [EntityDTO::GROUP_UPDATE])] EntityDTO $data Every time, it picks up the complete set of fields and ignores groups. |
Symfony 6.3 added the possibility for developers to map request data to typed objects. This release also included the addition of mapping query parameters.
This made me wonder why NelmioApiDocBundle wouldn't be able to automatically create basic documentation when these attributes are present.