bump minimum version to php 7.4 #2171
Conversation
|
What is the release policy for this bundle? |
This would result in a major version bump |
# Conflicts: # ModelDescriber/FormModelDescriber.php # ModelDescriber/ObjectModelDescriber.php # PropertyDescriber/ArrayPropertyDescriber.php # PropertyDescriber/BooleanPropertyDescriber.php # PropertyDescriber/CompoundPropertyDescriber.php # PropertyDescriber/DateTimePropertyDescriber.php # PropertyDescriber/FloatPropertyDescriber.php # PropertyDescriber/IntegerPropertyDescriber.php # PropertyDescriber/ObjectPropertyDescriber.php # PropertyDescriber/PropertyDescriberInterface.php # PropertyDescriber/StringPropertyDescriber.php # Tests/Functional/TestKernel.php
| @@ -25,7 +25,8 @@ | |||
| "symfony/options-resolver": "^5.4|^6.0|^7.0", | |||
| "symfony/property-info": "^5.4|^6.0|^7.0", | |||
| "symfony/routing": "^5.4|^6.0|^7.0", | |||
| "zircote/swagger-php": "^4.2.15", | |||
| "zircote/swagger-php": "^4.6.1", | |||
| "phpstan/phpdoc-parser": "^1.0", | |||
There was a problem hiding this comment.
Why in require? Is it used somewhere?
There was a problem hiding this comment.
This is related to failing https://github.com/nelmio/NelmioApiDocBundle/actions/runs/7767859362/job/21185134733?pr=2171
Might make more sense to pin this only in dev dependency
There was a problem hiding this comment.
Tested it, this does not work because the service gets removed
There was a problem hiding this comment.
I don't get it, are you adding a new dependency for every using project, because on 7.4 some tests are failing? Sounds wrong to me. If you plan a new major version anyway, kick 7.4.
There was a problem hiding this comment.
I agree that this is wrong. Still need to decide about what to do with this. Ideally I would go for PHP 8.1 & Symfony >6
There was a problem hiding this comment.
I'd always vote for moving forward, but hard to decide for a library, if 20% of all installations are still using PHP 7.4.
There was a problem hiding this comment.
I had another look at https://packagist.org/packages/nelmio/api-doc-bundle/php-stats#4 and now it report 10% of installs happen on PHP 7.4
I am considering that PHP 8.1 & Symfony >6 isn't that bad of an idea after all. Also together with the fact that we can still keep releasing fixes for v4.* if needed. This would also really help with cleaning up the codebase to new standards and start using phpstan.
There was a problem hiding this comment.
Anyways thanks a lot for your feedback @kevinpapst 😄
There was a problem hiding this comment.
Oh yes, there was a steep drop in January. You have my go 😁 but I have no project on 7, so I am a terrible advisor here. IMO these old EOL versions of PHP can still use old releases.
Other libs might have commercial interests and aim for maximum reach. But this is OSS and maintaining a free library should be fun! PHPStan is a huge bonus and if it keeps your spirits up, then it is worth doing so.
Related to #2136.
According to Packagist less than 1% use PHP 7.2 & less than 1% use PHP 7.3. https://packagist.org/packages/nelmio/api-doc-bundle/php-stats#4
Around 20% of installs still happen on PHP 7.4 which is the reason why I still would like to support this version for now.