chore: allow zircote/swagger-php v5 #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
changed the title
|
Ready for review! 😄 |
bobvandevijver
changed the title
bobvandevijver
force-pushed
the
patch-1
branch
from
9a7295c to
281bc89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2420 +/- ##
==========================================
- Coverage 89.56% 89.56% -0.01%
==========================================
Files 78 79 +1
Lines 2914 2912 -2
==========================================
- Hits 2610 2608 -2
Misses 304 304 ☔ View full report in Codecov by Sentry. |
bobvandevijver
force-pushed
the
patch-1
branch
2 times, most recently
from
1bc3b7b to
701ab46
Compare
|
Looking at the code coverage report: I do not think that the Because of the string before support I needed to upgrade the minimum to 4.11.1, because otherwise more code from zircote would needed to be integrated here. |
bobvandevijver
force-pushed
the
patch-1
branch
from
701ab46 to
1718b21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zircote/swagger-php v5 has been released, and seems to only require minimal updates. See https://github.com/zircote/swagger-php/blob/master/docs/guide/migrating-to-v5.md.
I did need to migrate the current processor implementation to the one that is using the new processor pipeline introduced with 4.10.0, which is why I bumped the minimum constraint. In order to not mess up dependency injection, I was required to wrap the Generator class in order to allow adding additional processors using the existing compiler pass.
What type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)