-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 5 support #98
Conversation
Seems this change is incompatible with Symfony 3.4: |
Maybe it works if you just remove the type hint? I'm not sure if that'll be allowed by PHP. |
Fixed now by removing the type hint. |
@dmaicher All tests passed successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I would also suggest to adjust the travis build to test all 3 major Symfony versions explicitly. This could be done after #99 is merged |
@thesunrise1983 could you add Symfony https://github.com/nelmio/NelmioSolariumBundle/blob/master/.travis.yml#L12 With PHP 7.4 should be enough I think 😊 |
Can a maintainer make the last change mentioned and merge this PR? I need to fork the repository in order to use this bundle for now. |
done. I did my best ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@Seldaek can we move forward with this? 😊 |
@thesunrise1983 @mhitza not sure if this will ever get released. I decided to maintain my own bundle instead: https://packagist.org/packages/dama/solarium-bundle Its fully compatible with Symfony 5 and requires the latest Solarium 5.2 |
Sorry for the late responses @thesunrise1983 and @dmaicher . To @dmaicher I noticed that you introduced phpstan into your fork, would you like to contribute it here and merge again your fork? I am willing to add you as co-maintainer of this bundle/repository, if @Seldaek agrees :) |
@thePanz I would be happy to help maintaining this bundle instead 😉 You can also reach me on Symfony Slack if you want to discuss things. |
These changes are working on Symfony 5.0 and Symfony 4.4, I didn't test on lower versions.