Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Manager plug-in does not display all files and directories on ruTorrent 5.0 #52

Closed
ppkhoa opened this issue Oct 13, 2024 · 8 comments · Fixed by #53
Closed

File Manager plug-in does not display all files and directories on ruTorrent 5.0 #52

ppkhoa opened this issue Oct 13, 2024 · 8 comments · Fixed by #53
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
Compatibility wit...

Comments

@ppkhoa
Copy link

ppkhoa commented Oct 13, 2024

If you have more than 34 items (files and directories included), the list just gets cut off and does not display any items from 35th entries forward. Scrolling down further and only blank spaces can be seen.
@anthonyryan1
Copy link
Contributor

The scroll issue bisects to this commit here: Novik/ruTorrent@b936446

I'll report back once I understand why that's the culprit.

I believe there's a separate, different issue with the [...] button in the Move/Copy dialog as well.

@anthonyryan1
Copy link
Contributor

The scrollbar problem stems from this line of CSS being removed:

div#tdcont > div {height: 100%;}

Adding it back fixes the file manager scrolling issue.

@anthonyryan1
Copy link
Contributor

For the next 5.0 issue, the copy and move buttons were broken by:

Novik/ruTorrent@3ed7cb8

anthonyryan1 added a commit to anthonyryan1/rutorrent-filemanager that referenced this issue Oct 14, 2024
@anthonyryan1
Fix ruTorrent 5.0 compatibility
3e7f060 
Couple minor fixes, and a much simpler API for managing directory selection

Closes nelu#52
@anthonyryan1 anthonyryan1 mentioned this issue Oct 14, 2024
Merged
nelu pushed a commit that referenced this issue Oct 15, 2024
@anthonyryan1
Fix ruTorrent 5.0 compatibility (#53)
74a5674 
Couple minor fixes, and a much simpler API for managing directory selection

Closes #52
@nelu
Copy link
Owner

nelu commented Oct 15, 2024

Thanks anthonyryan1 for the quick fixes.
We are collecting the fixes for ruTorrent v5 in this temporary branch: https://github.com/nelu/rutorrent-filemanager/tree/v5-compat
Till things get more stable, i noticed that more css needs to be ajusted to display properly with the changes on v5 (ex: dialog window icons offsets)

@nelu nelu added enhancement New feature or request help wanted Extra attention is needed labels Oct 15, 2024
@nelu nelu pinned this issue Oct 15, 2024
@nelu nelu added this to the Compatibility with ruTorrent v5 milestone Oct 15, 2024
@nelu
Copy link
Owner

nelu commented Oct 18, 2024

Fix of input onchange event for proper file names: Novik/ruTorrent#2745 and triggered here:

rutorrent-filemanager/views/dialog-archive.twig

Line 147 in 05fea01

self.updateFilePath($(this));

@stickz
Copy link
Contributor

stickz commented Oct 18, 2024 •
edited
Loading

We intend to support ruTorrent v4.3 for a while longer. There are platforms that would like to use it with file manager. Is it possible to keep a branch for v4.3?

I'll look into getting your PR merged for v5. We are working on v5.1 as well. We intend to drop support for v5.0 once it's released.

@nelu
Copy link
Owner

nelu commented Oct 18, 2024

Right now the latest release https://github.com/nelu/rutorrent-filemanager/releases/tag/v1.2 is stable and compatibile with ruTorrent v4.x and v3.x .

The compatibility changes for ruTorrent 5.x are on separate branch for now, and wont reach master untill a stable release of ruTorrent.

@nelu
Copy link
Owner

nelu commented Oct 20, 2024

If you have more than 34 items (files and directories included), the list just gets cut off and does not display any items from 35th entries forward. Scrolling down further and only blank spaces can be seen.

For the time being use this branch for ruTorrent v5.x : https://github.com/nelu/rutorrent-filemanager/tree/v5-compat

@nelu nelu closed this as completed Nov 15, 2024
nelu added a commit that referenced this issue Nov 18, 2024
@nelu @anthonyryan1
ruTorrent v5.x compatibility (#58)
587be5b 
* Fix ruTorrent 5.0 compatibility (#53)

Couple minor fixes, and a much simpler API for managing directory selection

Closes #52

* started splitting app js into smaller modules

* splitting app js into smaller modules

* app load after language translation in order
using event based calls

* handling multiple rDirBrowser instances in the same dialog window

* version bump

* input file using bootstrap
cache disable for twig templates
archive password field using bootstrap

* filename update on path change

* update twig to v1.17.1
clean dialog management

* change for v5 & clean css

* change for v5 & clean css

* ide friendly view file extensions

* ide friendly view file extensions
startbutton with dialogId

* move code to ui dialogs component
addjailpath with mixed arguments

* move manager to FileManagerAction
ide friendly object instances for ui components
move data frame dom creation to ui

* dialogs changes: move copy delete
force trailing slash for jaildir

* dialog views updates and fixes for v5

* revert dialog view file extension: a plugin for .twig file extnsion for ide works better

* format for twig files

* move files tab context menu handling in ui component
moved actions component to file

* moved code to ui filesystem component
cleanup unused methods

* fix context menu

* files in clipboard notification for hotkeys
fix file name display containing multiple spaces - issues/54

* clean dialogs
move code from dialog views to actions component
dialog hide method
dialogs getter and setters
clean ui dialogs method calls

* rename ui property browser to filenav to prevent misinterpretations with browser package

* basic tests for dialogs: delete and create dir

* working action history console button
updated file names check list styling for v5

* table interface methods

* using workaround to get row id
fixed context menu for both types of view
table event handlers method names

* using pre whitespace in css

* Fix template loading if ruTorrent is hosted in a directory (#59)

flm.utils.buildPath() returns an asbolute path, which is generally desirable
but if someone were hosting rutorrent at a subdirectory like /rutorrent/ then
it will load from the domain root, instead of relative to /rutorrent/

Change "/" prefix to "./" to load relative to whatever page is currently loaded.

Also disambiguate the isValidPath() comment.

* ready method in filemanager plugin

* password macro input groups localisation

* fix table context menu select entries: restrict to right click

* fix double click navigation
method for setting fileNav.selectedTarget from a table entry
getter and setter for fileNav.selectedTarget

* using bootstrap for navigation head

* add css classes to rDirBrowser
css style to pathbrowser dialogs

---------

Co-authored-by: Anthony Ryan <anthonyryan1@gmail.com>
Co-authored-by: nelu <nelu@github.com>
@nelu nelu unpinned this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
Compatibility with ruTorrent v5 upstream
Development

Successfully merging a pull request may close this issue.

Fix ruTorrent 5.0 compatibility anthonyryan1/rutorrent-filemanager
4 participants
@anthonyryan1 @nelu @ppkhoa @stickz