Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Pagination in search results does not work #50

Closed
ptahchiev opened this issue Jun 9, 2015 · 4 comments
Closed

[backend] Pagination in search results does not work #50

ptahchiev opened this issue Jun 9, 2015 · 4 comments
Labels
Milestone

Comments

@ptahchiev
Copy link
Contributor

  • search for any entity
  • a table with search results and pagination appears
  • click on the next page or previous page - doesn't work
  • change number of shown entities - doesn't work.
  • go to last/first page - doesn't work.
@ovitanov
Copy link
Contributor

The paging problem is fixed, but I noticed some other possible issues:

  1. In search results for product the 29th item is huge, causing the request to timeout and not update the grid (the request for loading the first 10 items is about 30KB, and the request for items 21-30 is over 10MB by the time it times out)
  2. The sorting is local, so it is based only on the items in the current page

@ptahchiev
Copy link
Contributor Author

I believe what's happening is probably EXTJS is loading ALL the data (from page1 to page 20) and it probably manually trims only the last page to be shown. So loading all the data is slow and stupid. We should do all pagination and sorting on the server. You can pass parameters ?page ?size ?sort so that this happens on the server, and not on the clientside.

@ptahchiev
Copy link
Contributor Author

I also see that when you change the page-size to 1000 the results shown are still 10. This needs to be fixed and we also need a selenium test for it.

@ovitanov
Copy link
Contributor

Default request timeout in the extjs proxy class is 30s, which means that any request, lasting more than 30s is going to be terminated and as a result the grid will not be updated. If you like I can increase the timeout.
In the case of Product results grid the 29th item is taking ages to load, therefore any page size > 28 (50, 100, 1000) times out

ovitanov added a commit that referenced this issue Jun 26, 2015
@ptahchiev ptahchiev added this to the 0.7 milestone Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants