Format full PostgreSQL func/proc parameter syntax

Also BEGIN ATOMIC .. END
nene · Jan 27, 2024 · 46be069 · 46be069
1 parent 27b83ae
commit 46be069
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 8 deletions.
diff --git a/src/syntax/function.ts b/src/syntax/function.ts
@@ -25,7 +25,9 @@ export const functionMap: Partial<CstToDocMap<AllFunctionNodes>> = {
           ),
         ],
   ],
-  function_param: (print) => print.spaced(["mode", "name", "dataType"]),
+  function_param: (print) =>
+    print.spaced(["mode", "name", "dataType", "default"]),
+  function_param_default: (print) => print.spaced(["operator", "expr"]),
   drop_function_stmt: (print) =>
     group([
       print.spaced(["dropKw", "tableKw", "functionKw", "ifExistsKw", "name"]),

diff --git a/src/syntax/procedural_language.ts b/src/syntax/procedural_language.ts
@@ -12,7 +12,7 @@ import { CstToDocMap } from "../CstToDocMap";
 export const proceduralLanguageMap: CstToDocMap<AllProceduralNodes> = {
   // BEGIN .. END
   block_stmt: (print, node) => [
-    print("beginKw"),
+    print.spaced(["beginKw", "atomicKw"]),
     indent([hardline, stripTrailingHardline(print("program"))]),
     node.exception ? [hardline, print("exception")] : [],
     hardline,

diff --git a/test/ddl/function.test.ts b/test/ddl/function.test.ts
@@ -11,13 +11,14 @@ describe("function", () => {
     });
 
     it(`formats long parameter list to multiple lines`, async () => {
-      await testBigquery(dedent`
+      await testPostgresql(dedent`
         CREATE FUNCTION my_func(
-          first_name STRING,
-          last_name STRING,
-          year_of_birth INT64
-        ) AS
-          (SELECT * FROM client)
+          IN first_name TEXT,
+          OUT last_name TEXT,
+          year_of_birth INT DEFAULT 2000,
+          INOUT age INT = 0,
+          VARIADIC other_names TEXT[]
+        ) AS 'SELECT 1'
       `);
     });
 

diff --git a/test/ddl/procedure.test.ts b/test/ddl/procedure.test.ts
@@ -40,6 +40,17 @@ describe("procedure", () => {
       );
     });
 
+    it(`formats default parameter values`, async () => {
+      await testPostgresql(
+        dedent`
+          CREATE PROCEDURE eliminate_tbl(id INT = 1, TEXT DEFAULT 'foo')
+          BEGIN ATOMIC
+            DROP TABLE my_table;
+          END
+        `,
+      );
+    });
+
     it(`formats OPTIONS (..)`, async () => {
       await testBigquery(
         dedent`