BREAKING! AlterViewStmt.actions now contains ListExpr

Properly expecting multiple ALTER VIEW actions to be comma-separated.
nene · Jan 31, 2024 · 4ab708d · 4ab708d
1 parent f493e16
commit 4ab708d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/cst/View.ts b/src/cst/View.ts
@@ -73,5 +73,5 @@ export interface AlterViewStmt extends BaseNode {
   ifExistsKw?: [Keyword<"IF">, Keyword<"EXISTS">];
   name: EntityName;
   columns?: ParenExpr<ListExpr<Identifier>>;
-  actions: (AlterViewAction | AsClause<SubSelect>)[];
+  actions: ListExpr<AlterViewAction | AsClause<SubSelect>>;
 }
diff --git a/src/parser.pegjs b/src/parser.pegjs
@@ -1858,7 +1858,7 @@ alter_view_stmt
     ifKw:(__ if_exists)?
     name:(__ entity_name)
     cols:(__ paren$list$column)?
-    actions:(__ alter_view_action)+ {
+    actions:(__ list$alter_view_action) {
       return loc({
         type: "alter_view_stmt",
         alterKw,
@@ -1867,7 +1867,7 @@ alter_view_stmt
         ifExistsKw: read(ifKw),
         name: read(name),
         columns: read(cols),
-        actions: actions.map(read),
+        actions: read(actions),
       });
     }
 
@@ -6109,6 +6109,7 @@ list$alias$func_call = .
 list$alias$paren$list$column = .
 list$alias$relation_expr = .
 list$alter_action = .
+list$alter_view_action = .
 list$column = .
 list$column_assignment = .
 list$column_definition = .

diff --git a/test/ddl/view.test.ts b/test/ddl/view.test.ts
@@ -219,6 +219,14 @@ describe("view", () => {
         testWc(`ALTER MATERIALIZED VIEW my_view ${action}`);
       }
 
+      it("supports multiple alter-actions", () => {
+        testWc(`
+          ALTER MATERIALIZED VIEW my_view
+            CLUSTER ON my_index,
+            SET TABLESPACE foo
+        `);
+      });
+
       it("supports SET TABLESPACE", () => {
         testAlterMatWc("SET TABLESPACE foo");
         testAlterMatWc("SET TABLESPACE foo NOWAIT");