Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for BigQuery's GROUP BY ALL (documentation, release notes).
I've checked, and just allowing keyword ALL would have been enough as well (there was no need to introduce a new
group_by_all
type). I introduced the newgroup_by_all
type because I felt it was preferrable to be explicit, rather than relying on a solution that "worked by accident", but I'm a little hesitant about this. If you'd prefer the simple solution, feel free to use that instead.In addition, I also considered a separate GROUP BY ALL clause, which would have disallowed mixing GROUP BY ALL with elements from other syntax variants. I decided against this because you wrote you didn't intend this to be an SQL validator.