Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support GROUP BY ALL in BigQuery #101

Merged
merged 1 commit into from
Jan 1, 2025
Merged

support GROUP BY ALL in BigQuery #101

merged 1 commit into from
Jan 1, 2025

Conversation

bmagyarkuti
Copy link
Contributor

@bmagyarkuti bmagyarkuti commented Jan 1, 2025

Add support for BigQuery's GROUP BY ALL (documentation, release notes).

I've checked, and just allowing keyword ALL would have been enough as well (there was no need to introduce a new group_by_all type). I introduced the new group_by_all type because I felt it was preferrable to be explicit, rather than relying on a solution that "worked by accident", but I'm a little hesitant about this. If you'd prefer the simple solution, feel free to use that instead.

In addition, I also considered a separate GROUP BY ALL clause, which would have disallowed mixing GROUP BY ALL with elements from other syntax variants. I decided against this because you wrote you didn't intend this to be an SQL validator.

@nene
Copy link
Owner

nene commented Jan 1, 2025

Thanks a lot.

This is somewhat confusing case as it looks super similar to the GROUP BY [ALL | DISTINCT] expr syntax supported by PostgreSQL, but it really has a completely different meaning.

I think your solution is perfect.

@nene nene merged commit 72a8f3e into nene:master Jan 1, 2025
3 checks passed
@bmagyarkuti
Copy link
Contributor Author

Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants