Fix bug with hidden_to_memory and no hidden_cell #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error if
hidden_to_memory=True
andhidden_cell=None
(since there is no hidden state to direct to the memory input). This handles that case. Note that this is technically equivalent tomemory_to_memory=True
, so it's kind of a weird thing to do, but I thought it was worth supporting so that people doing parameter sweeps and things like that can see the effect of this case rather than having to particularly avoid it.