Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firing rate scaling option to Converter #134

Merged
merged 9 commits into from
Mar 5, 2020
Merged

Conversation

drasmuss
Copy link
Member

Also added some documentation on the tips and tricks page to address the issue of low firing rates.

@drasmuss drasmuss force-pushed the converter-rates branch 2 times, most recently from ca957e5 to 1131cf3 Compare February 28, 2020 15:00
@drasmuss drasmuss mentioned this pull request Mar 4, 2020
1 task
@tbekolay tbekolay changed the base branch from upsample to master March 5, 2020 19:22
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it would be great to have a more comprehensive example using scale_firing_rates to train something, but that seems outside the scope of this PR and something we'll likely do when we look at adding more examples / tutorials anyhow. Will merge when CI is happy.

@drasmuss
Copy link
Member Author

drasmuss commented Mar 5, 2020

Yeah we definitely should have an example like that, as it's a question that has come up a lot on the forums.

@tbekolay tbekolay merged commit ca2e788 into master Mar 5, 2020
@tbekolay tbekolay deleted the converter-rates branch March 5, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants