Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call config.addini to eliminate warnings in downstream repos #26

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

tbekolay
Copy link
Member

Warnings were being thrown in NengoCore because pytest-plt didn't call config.addini for configuration options.

This PR also updates to the lastest version of NengoBones.

@hunse
Copy link
Collaborator

hunse commented Nov 24, 2021

These changes (e.g. using f-strings) will mean that we no longer support Python 3.5. I'm fine with this (I noticed you also changed the tests to no longer test 3.5, so I'm guessing you are too), but we should update both the min python version and the classifiers in nengobones.yml accordingly. (Also, assuming the tests pass on 3.8/3.9, we can add those classifiers.)

@tbekolay
Copy link
Member Author

Yes, Python 3.5 is past its end of life so we have no plans to support it across any of our projects. The min Python version (in NengoBones) defaults to 3.6, but yes we should definitely change the classifiers. Made that change, and updated appveyor to hopefully pass this time ...

@tbekolay tbekolay force-pushed the fix-addini branch 2 times, most recently from 6df5bc5 to cf80513 Compare November 24, 2021 21:34
Copy link
Collaborator

@hunse hunse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also tested locally that the config options still work.

Let me know when the tests pass and I'll merge.

And update .nengobones.yml to reflect recent changes.
This eliminates warnings that were being raised in packages
using the config options exposed by pytest-plt.

This commit also fixes style issues raised by more recent
version of NengoBones, Pylint, flake8, etc.
@tbekolay
Copy link
Member Author

CI is all passing now; coverage isn't being collected correctly, but I think we should not worry about that for now.

@hunse hunse merged commit 2b0c031 into master Nov 25, 2021
@hunse hunse deleted the fix-addini branch November 25, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants