Merge #848 #900 #903 #906

848: docs(Reference): Give object parameters a name if they will be includ… r=davemneo a=afragapane With dgeni typescript parsing, function parameters display awkwardly if they are unnamed objects. Giving them a name like "options" fixes the issue and displays them properly. #702 900: chore(dep-update): Updating code style of ReferenceGrid r=dicarlo2 a=davemneo ### Requirements Update asserted code per new lint rules. ### Description of the Change remove 'any' type casting from identified file. ### Test Plan Standard lint test yarn lint ### Benefits Green lint test. ### Applicable Issues #758 903: chore(deps): update dependency @reactivex/ix-es2015-cjs to v2.4.3 r=davemneo a=renovate[bot] This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | @reactivex/ix-es2015-cjs | devDependencies | minor | `2.3.5` -> `2.4.3` | [source](https://renovatebot.com/gh/ReactiveX/IxJS) | --- ### Release Notes <details> <summary>ReactiveX/IxJS</summary> ### [`v2.4.3`](https://renovatebot.com/gh/ReactiveX/IxJS/releases/v2.4.3) [Compare Source](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.4.2...v2.4.3) New release of IxJS is now available. This includes a number of new features and improvements to existing APIs. #### New APIs are available The following APIs have been added to `AsyncIterable` - [`batch`](https://renovatebot.com/gh/ReactiveX/IxJS/blob/master/src/asynciterable/batch.ts) - [`toNodeStream`](https://renovatebot.com/gh/ReactiveX/IxJS/blob/master/src/asynciterable/tonodestream.ts) The following APIs have been added to `Iterable` - [`toNodeStream`](https://renovatebot.com/gh/ReactiveX/IxJS/blob/master/src/iterable/tonodestream.ts) ##### API Fixes - [`AsyncIterable.fromNodeStream`](https://renovatebot.com/gh/ReactiveX/IxJS/blob/master/src/asynciterable/fromnodestream.ts) has been optimized for streams and `AsyncIterables` - [`AsyncIterable.prototype.pipe`](https://renovatebot.com/gh/ReactiveX/IxJS/blob/master/src/Ix.node.ts) now accepts Node.js `WritableStream` values in addition to operators. ##### Bug Fixes - **dependencies:** add rxjs to the production dependencies list ([54e5cf7](https://renovatebot.com/gh/ReactiveX/IxJS/commit/54e5cf7)) ### [`v2.4.2`](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.4.0...v2.4.2) [Compare Source](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.4.0...v2.4.2) ### [`v2.4.0`](https://renovatebot.com/gh/ReactiveX/IxJS/blob/master/CHANGELOG.md#240httpsgithubcomReactiveXIxJScomparev235v240-2019-01-03) [Compare Source](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.3.5...v2.4.0) ##### Bug Fixes - **toObservable:** adds symbol-observable for rxjs interop ([273e697](https://renovatebot.com/gh/ReactiveX/IxJS/commit/273e697)), closes [#245](https://renovatebot.com/gh/ReactiveX/IxJS/issues/245) ##### Features - add support for passing Node WritableStreams to `AsyncIterableX#pipe()` ([#257](https://renovatebot.com/gh/ReactiveX/IxJS/issues/257)) ([9a1c5cc](https://renovatebot.com/gh/ReactiveX/IxJS/commit/9a1c5cc)) - add `AsyncIterableX#toNodeStream()` ([#257](https://renovatebot.com/gh/ReactiveX/IxJS/issues/257)) ([9a1c5cc](https://renovatebot.com/gh/ReactiveX/IxJS/commit/9a1c5cc)) - add `AsyncIterableX#batch()` ([#222](https://renovatebot.com/gh/ReactiveX/IxJS/issues/222)) ([9c9bd7e](https://renovatebot.com/gh/ReactiveX/IxJS/commit/9c9bd7e)) #### [2.3.5](https://renovatebot.com/gh/ReactiveX/IxJS/compare/9.2.0...v2.3.5) (2018-02-19) ##### Bug Fixes - **compile:** adding some missing exports to deal with typescript 2.7.x compat issue ([0b0c837](https://renovatebot.com/gh/ReactiveX/IxJS/commit/0b0c837)), closes [#214](https://renovatebot.com/gh/ReactiveX/IxJS/issues/214) ##### Features - **orderby:** add piped orderby ([#190](https://renovatebot.com/gh/ReactiveX/IxJS/issues/190)) ([aaa527a](https://renovatebot.com/gh/ReactiveX/IxJS/commit/aaa527a)) #### [2.3.4](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.3.3...v2.3.4) (2017-11-29) ##### Bug Fixes - **typings:** Fix optional predicate typings for user-defined typeguard predicates ([fedd563](https://renovatebot.com/gh/ReactiveX/IxJS/commit/fedd563)) - **typings:** workaround typescript bugs when noImplicitAny or strictNullChecks are not true ([ce03239](https://renovatebot.com/gh/ReactiveX/IxJS/commit/ce03239)) #### [2.3.3](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.3.2...v2.3.3) (2017-11-21) ##### Reverts - **npm:** revert [`4493754`](https://renovatebot.com/gh/ReactiveX/IxJS/commit/4493754d9fbbc061347d8ef785704b61ecb486c5) ([564c600](https://renovatebot.com/gh/ReactiveX/IxJS/commit/564c600)), closes [#163](https://renovatebot.com/gh/ReactiveX/IxJS/issues/163) #### [2.3.2](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.3.1...v2.3.2) (2017-11-21) ##### Bug Fixes - **fromnodestream:** enable fromnodestream tests, fix minification problems ([#156](https://renovatebot.com/gh/ReactiveX/IxJS/issues/156)) ([745d763](https://renovatebot.com/gh/ReactiveX/IxJS/commit/745d763)) - **fromnodestream:** type fromNodeStream to accept NodeJS.ReadableStream interface ([3cbf2dd](https://renovatebot.com/gh/ReactiveX/IxJS/commit/3cbf2dd)) - **FromObservableAsyncIterable:** Fix handling of asynchronously emitting Observables ([#150](https://renovatebot.com/gh/ReactiveX/IxJS/issues/150)) ([2c7222c](https://renovatebot.com/gh/ReactiveX/IxJS/commit/2c7222c)) - **readme:** fix lettable syntax ([0e46181](https://renovatebot.com/gh/ReactiveX/IxJS/commit/0e46181)) ##### Features - **as:** Add static as convenience methods to wrap values as Async/Iterables ([#154](https://renovatebot.com/gh/ReactiveX/IxJS/issues/154)) ([79a14c5](https://renovatebot.com/gh/ReactiveX/IxJS/commit/79a14c5)) #### [2.3.1](https://renovatebot.com/gh/ReactiveX/IxJS/compare/v2.3.0...v2.3.1) (2017-11-08) ##### Bug Fixes - **single:** make iterable prototype single predicate an optional parameter again ([2bea5ab](https://renovatebot.com/gh/ReactiveX/IxJS/commit/2bea5ab)), closes [/github.com/ReactiveX/IxJS/pull/83#issuecomment-341832266](https://renovatebot.com/gh//github.com/ReactiveX/IxJS/pull/83/issues/issuecomment-341832266) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#neo-one-suite/neo-one). 906: chore(deps): update dependency cache-loader to v2.0.1 r=davemneo a=renovate[bot] This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | cache-loader | devDependencies | patch | `2.0.0` -> `2.0.1` | [source](https://renovatebot.com/gh/webpack-contrib/cache-loader) | --- ### Release Notes <details> <summary>webpack-contrib/cache-loader</summary> ### [`v2.0.1`](https://renovatebot.com/gh/webpack-contrib/cache-loader/blob/master/CHANGELOG.md#201httpsgithubcomwebpack-contribcache-loadercomparev200v201-2019-01-04) [Compare Source](https://renovatebot.com/gh/webpack-contrib/cache-loader/compare/v2.0.0...v2.0.1) ##### Bug Fixes - generate normalized cache context relative paths ([#54](https://renovatebot.com/gh/webpack-contrib/cache-loader/issues/54)) ([5b37474](https://renovatebot.com/gh/webpack-contrib/cache-loader/commit/5b37474)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#neo-one-suite/neo-one). Co-authored-by: afragapane <ahfragapane@gmail.com> Co-authored-by: Dave M <david.mathiesen@neotracker.io> Co-authored-by: Renovate Bot <bot@renovateapp.com>
neo-one-suite · Jan 5, 2019 · 1f48343 · 1f48343
5 parents bbde4a7 + 4693ce9 + cba2193 + 8be112b + 8b3b55a
commit 1f48343
Show file tree

Hide file tree

Showing 8 changed files with 44 additions and 27 deletions.
diff --git a/package.json b/package.json
@@ -165,7 +165,7 @@
     "babel-plugin-styled-components": "1.10.0",
     "babel-plugin-transform-imports": "1.5.1",
     "babel-plugin-universal-import": "3.1.2",
-    "cache-loader": "2.0.0",
+    "cache-loader": "2.0.1",
     "codecov": "3.1.0",
     "commitizen": "3.0.5",
     "compression-webpack-plugin": "2.0.0",

diff --git a/packages/neo-one-client-common/src/helpers.ts b/packages/neo-one-client-common/src/helpers.ts
@@ -123,13 +123,12 @@ export function isNEP2(encryptedKey: string): boolean {
  * @param privateKey hex-encoded private key
  * @returns NEP-2 format encrypted key
  */
-export async function encryptNEP2({
-  password,
-  privateKey,
-}: {
+export async function encryptNEP2(options: {
   readonly password: string;
   readonly privateKey: PrivateKeyString;
 }): Promise<string> {
+  const { password, privateKey } = options;
+
   return crypto.encryptNEP2({
     addressVersion: common.NEO_ADDRESS_VERSION,
     privateKey: common.stringToPrivateKey(privateKey),
@@ -144,13 +143,11 @@ export async function encryptNEP2({
  * @param encryptedKey NEP-2 format encrypted key
  * @returns hex-encoded private key
  */
-export async function decryptNEP2({
-  password,
-  encryptedKey,
-}: {
+export async function decryptNEP2(options: {
   readonly password: string;
   readonly encryptedKey: string;
 }): Promise<PrivateKeyString> {
+  const { password, encryptedKey } = options;
   const privateKey = await crypto.decryptNEP2({
     addressVersion: common.NEO_ADDRESS_VERSION,
     encryptedKey,

diff --git a/packages/neo-one-client-core/src/provider/NEOONEOneDataProvider.ts b/packages/neo-one-client-core/src/provider/NEOONEOneDataProvider.ts
@@ -50,13 +50,8 @@ export class NEOONEOneDataProvider implements DeveloperProvider {
   private readonly iterBlocksFetchTimeoutMS: number | undefined;
   private readonly iterBlocksBatchSize: number | undefined;
 
-  public constructor({
-    network,
-    projectID,
-    port,
-    iterBlocksFetchTimeoutMS,
-    iterBlocksBatchSize,
-  }: NEOONEOneDataProviderOptions) {
+  public constructor(options: NEOONEOneDataProviderOptions) {
+    const { network, projectID, port, iterBlocksFetchTimeoutMS, iterBlocksBatchSize } = options;
     this.network = network;
     this.projectID = projectID;
     this.port = port;

diff --git a/packages/neo-one-client-core/src/provider/NEOONEProvider.ts b/packages/neo-one-client-core/src/provider/NEOONEProvider.ts
@@ -58,7 +58,8 @@ export class NEOONEProvider implements Provider {
     return this.networksInternal$.getValue();
   }
 
-  public addNetwork({ network, rpcURL }: { readonly network: NetworkType; readonly rpcURL: string }): void {
+  public addNetwork(options: { readonly network: NetworkType; readonly rpcURL: string }): void {
+    const { network, rpcURL } = options;
     this.mutableProviders[network] = new NEOONEDataProvider({ network, rpcURL });
     const networks = this.networksInternal$.value.filter((net) => network !== net).concat([network]);
     this.networksInternal$.next(networks);

diff --git a/packages/neo-one-client-core/src/user/LocalUserAccountProvider.ts b/packages/neo-one-client-core/src/user/LocalUserAccountProvider.ts
@@ -222,7 +222,8 @@ export class LocalUserAccountProvider<TKeyStore extends KeyStore, TProvider exte
   protected readonly mutableUsedOutputs: Set<string>;
   protected mutableBlockCount: number;
 
-  public constructor({ keystore, provider }: { readonly keystore: TKeyStore; readonly provider: TProvider }) {
+  public constructor(constructorOptions: { readonly keystore: TKeyStore; readonly provider: TProvider }) {
+    const { keystore, provider } = constructorOptions;
     this.keystore = keystore;
     this.provider = provider;
 

diff --git a/packages/neo-one-client-full-core/package.json b/packages/neo-one-client-full-core/package.json
@@ -18,7 +18,7 @@
   },
   "devDependencies": {
     "@neo-one/node-core": "^1.0.1",
-    "@reactivex/ix-es2015-cjs": "2.3.5",
+    "@reactivex/ix-es2015-cjs": "2.4.3",
     "@types/bn.js": "4.11.3",
     "bn.js": "4.11.8",
     "rxjs": "6.3.3"

diff --git a/packages/neo-one-website/src/components/reference/ReferenceGrid.tsx b/packages/neo-one-website/src/components/reference/ReferenceGrid.tsx
@@ -1,4 +1,3 @@
-// tslint:disable no-any
 import { Box, TextInput } from '@neo-one/react-common';
 import * as React from 'react';
 import styled from 'styled-components';
@@ -45,7 +44,7 @@ export const ReferenceGrid = ({ content, ...props }: Props) => {
     <Wrapper {...props}>
       <FilterWrapper>
         <TypeFilter selected={typeFilter} onChange={setTypeFilter} />
-        <StyledInput placeholder="Filter" onChange={(event) => setTextFilter((event.target as any).value)} />
+        <StyledInput placeholder="Filter" onChange={(event) => setTextFilter(event.target.value)} />
       </FilterWrapper>
       <ReferenceLayout>
         {content

diff --git a/yarn.lock b/yarn.lock
@@ -2249,7 +2249,16 @@
     react-lifecycles-compat "^3.0.4"
     warning "^3.0.0"
 
-"@reactivex/ix-es2015-cjs@2.3.5", "@reactivex/ix-es2015-cjs@^2.3.5":
+"@reactivex/ix-es2015-cjs@2.4.3":
+  version "2.4.3"
+  resolved "https://registry.yarnpkg.com/@reactivex/ix-es2015-cjs/-/ix-es2015-cjs-2.4.3.tgz#9745fa341d9ee61e68fbea797cf72ab2cfba0013"
+  dependencies:
+    "@types/node" "^10.12.18"
+    is-stream "1.1.0"
+    rxjs "5.5.11"
+    tslib "^1.9.3"
+
+"@reactivex/ix-es2015-cjs@^2.3.5":
   version "2.3.5"
   resolved "https://registry.yarnpkg.com/@reactivex/ix-es2015-cjs/-/ix-es2015-cjs-2.3.5.tgz#f50adc537e0c1fa91d68f5870bbc7e3d1ec9d327"
   dependencies:
@@ -2848,6 +2857,10 @@
   version "10.12.9"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.9.tgz#a07bfa74331471e1dc22a47eb72026843f7b95c8"
 
+"@types/node@^10.12.18":
+  version "10.12.18"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.18.tgz#1d3ca764718915584fcd9f6344621b7672665c67"
+
 "@types/node@^9.4.6":
   version "9.6.39"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-9.6.39.tgz#111cb4f5591cb6945aad34733b4e40bfd59b58fc"
@@ -5228,13 +5241,14 @@ cache-content-type@^1.0.0:
     mime-types "^2.1.18"
     ylru "^1.2.0"
 
-cache-loader@2.0.0:
-  version "2.0.0"
-  resolved "https://registry.yarnpkg.com/cache-loader/-/cache-loader-2.0.0.tgz#75cad9eb1e1c882c2b8c31ea008b41ebb0787de0"
+cache-loader@2.0.1:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/cache-loader/-/cache-loader-2.0.1.tgz#5758f41a62d7c23941e3c3c7016e6faeb03acb07"
   dependencies:
     loader-utils "^1.1.0"
     mkdirp "^0.5.1"
-    neo-async "^2.5.0"
+    neo-async "^2.6.0"
+    normalize-path "^3.0.0"
     schema-utils "^1.0.0"
 
 cachedir@1.3.0:
@@ -10466,7 +10480,7 @@ is-stream-ended@^0.1.4:
   version "0.1.4"
   resolved "https://registry.yarnpkg.com/is-stream-ended/-/is-stream-ended-0.1.4.tgz#f50224e95e06bce0e356d440a4827cd35b267eda"
 
-is-stream@^1.0.0, is-stream@^1.0.1, is-stream@^1.1.0:
+is-stream@1.1.0, is-stream@^1.0.0, is-stream@^1.0.1, is-stream@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/is-stream/-/is-stream-1.1.0.tgz#12d4a3dd4e68e0b79ceb8dbc84173ae80d91ca44"
 
@@ -13465,6 +13479,10 @@ normalize-path@^2.0.1, normalize-path@^2.1.1:
   dependencies:
     remove-trailing-separator "^1.0.1"
 
+normalize-path@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/normalize-path/-/normalize-path-3.0.0.tgz#0dcd69ff23a1c9b11fd0978316644a0388216a65"
+
 normalize-range@^0.1.2:
   version "0.1.2"
   resolved "https://registry.yarnpkg.com/normalize-range/-/normalize-range-0.1.2.tgz#2d10c06bdfd312ea9777695a4d28439456b75942"
@@ -16544,6 +16562,12 @@ rxjs-tslint-rules@4.14.1:
     tslib "^1.8.0"
     tsutils "^3.0.0"
 
+rxjs@5.5.11:
+  version "5.5.11"
+  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-5.5.11.tgz#f733027ca43e3bec6b994473be4ab98ad43ced87"
+  dependencies:
+    symbol-observable "1.0.1"
+
 rxjs@6.3.3, rxjs@^6.1.0, rxjs@^6.3.3:
   version "6.3.3"
   resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.3.3.tgz#3c6a7fa420e844a81390fb1158a9ec614f4bad55"