Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Alternative Transaction Models #1881

Closed
2 of 3 tasks
danwbyrne opened this issue Dec 2, 2019 · 1 comment
Closed
2 of 3 tasks

Delete Alternative Transaction Models #1881

danwbyrne opened this issue Dec 2, 2019 · 1 comment
Assignees
@danwbyrne
Labels
area/client Categorize issue or PR as client (@neo-one/client) related priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@danwbyrne
Copy link
Contributor

danwbyrne commented Dec 2, 2019 •
edited by spencercorwin
Loading

https://github.com/Tommo-L/NEO3-Development-Guide#transactions

Transactions have been fundamentally reworked beginning with the removal of all transaction types besides a singular transaction model. This will probably be the most involved changes of the 3.0 client migration and may warrant other issues in the future. For now the tasks needed to be complete are:

  • Remove every transaction except InvocationTransaction and rename to just Transaction.
  • Update the current Transaction model to match the model changes made in 3.0.
  • discard the UTXO model for NEO and GAS and use the account model from the native contract. We have a lot of code involving inputs/outputs and calculating balances so this will be ~80% removal of old code.
@danwbyrne danwbyrne added area/client Categorize issue or PR as client (@neo-one/client) related priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 2, 2019
@danwbyrne danwbyrne self-assigned this Dec 2, 2019
@spencercorwin spencercorwin changed the title [Neo 3.0] Delete Alternative Transaction Models Delete Alternative Transaction Models May 22, 2020
@spencercorwin spencercorwin mentioned this issue Aug 20, 2020
Merged
@spencercorwin spencercorwin mentioned this issue Aug 27, 2020
Merged
@spencercorwin
Copy link
Collaborator

Covered by #2142 and #1975, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwbyrne danwbyrne

Labels
area/client Categorize issue or PR as client (@neo-one/client) related priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danwbyrne @spencercorwin