Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-core models/classes #2142

Closed
12 of 19 tasks
danwbyrne opened this issue Aug 18, 2020 · 1 comment
Closed
12 of 19 tasks

Update node-core models/classes #2142

danwbyrne opened this issue Aug 18, 2020 · 1 comment
Assignees
@danwbyrne
Labels
area/client Categorize issue or PR as client (@neo-one/client) related area/node Categorize issue or PR as node (@neo-one/node) related priority/important-soon Must be staffed and worked on either currently, or very soon.

Comments

@danwbyrne
Copy link
Contributor

danwbyrne commented Aug 18, 2020 •
edited
Loading

Finish converting these @neo-one/node-core models (I had a list before but they all need reviewing at this point):

  • Block
  • BlockBase
  • Blockchain
  • ConsensusData
  • Contract
  • ContractPropertyState
  • Header
  • Signer
  • StorageFlags
  • TrimmedBlock
  • Validator
  • Witness

Possibly needs a full rewrite / has been removed:

  • Account
  • AccountInput
  • AccountUnclaimed
  • AccountUnspent
  • Asset
  • AssetType
  • CallReceipt
@danwbyrne danwbyrne self-assigned this Aug 18, 2020
@danwbyrne danwbyrne added area/client Categorize issue or PR as client (@neo-one/client) related area/node Categorize issue or PR as node (@neo-one/node) related priority/important-soon Must be staffed and worked on either currently, or very soon. labels Aug 18, 2020
@spencercorwin spencercorwin changed the title @neo-one/node-core conversion Update node-core models/classes Aug 30, 2020
@spencercorwin spencercorwin mentioned this issue Aug 30, 2020
Closed
3 tasks
@spencercorwin spencercorwin mentioned this issue Oct 13, 2020
Merged
@danwbyrne
Copy link
Contributor Author

danwbyrne commented Oct 19, 2020 •
edited
Loading

Most of these are resolved, see #2191 for unresolved Notification issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwbyrne danwbyrne

Labels
area/client Categorize issue or PR as client (@neo-one/client) related area/node Categorize issue or PR as node (@neo-one/node) related priority/important-soon Must be staffed and worked on either currently, or very soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danwbyrne