Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewire Notification type on client side #2191

Closed
danwbyrne opened this issue Oct 19, 2020 · 2 comments
Closed

Rewire Notification type on client side #2191

danwbyrne opened this issue Oct 19, 2020 · 2 comments
Labels
area/client Categorize issue or PR as client (@neo-one/client) related

Comments

@danwbyrne
Copy link
Contributor

After the migration to 3.0 the NotificationRaw & NotificationJSON types in @neo-one/client-common are not what they used to be / need to be reformed.
@danwbyrne danwbyrne added the area/client Categorize issue or PR as client (@neo-one/client) related label Oct 19, 2020
@danwbyrne danwbyrne mentioned this issue Oct 19, 2020
Closed
19 tasks
@spencercorwin
Copy link
Collaborator

Also look at notificationToJSON function in neo-one-node-core/src/utils/notificationToJSON.ts

@spencercorwin
Copy link
Collaborator

Duplicated in #2218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/client Categorize issue or PR as client (@neo-one/client) related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danwbyrne @spencercorwin