Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RPC methods/handlers #1882

Closed
danwbyrne opened this issue Dec 2, 2019 · 3 comments
Closed

Update RPC methods/handlers #1882

danwbyrne opened this issue Dec 2, 2019 · 3 comments
Assignees
@danwbyrne
Labels
area/client Categorize issue or PR as client (@neo-one/client) related area/node Categorize issue or PR as node (@neo-one/node) related priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@danwbyrne
Copy link
Contributor

danwbyrne commented Dec 2, 2019 •
edited by spencercorwin
Loading

https://github.com/Tommo-L/NEO3-Development-Guide#rpc

Update the RPC server methods/handlers to match C# Neo3 code.

Packages:

  • node-rpc-handler

Blocked by blockchain storage changes and a few other things.
@danwbyrne danwbyrne added area/client Categorize issue or PR as client (@neo-one/client) related priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 2, 2019
@danwbyrne danwbyrne self-assigned this Dec 2, 2019
@danwbyrne
Copy link
Contributor Author

danwbyrne commented Dec 3, 2019 •
edited
Loading

#151

implement any missing RPC calls if there are any after the change.

@danwbyrne
Copy link
Contributor Author

https://github.com/Tommo-L/NEO3-Development-Guide/tree/master/en/RPC/api

do these wallet APIs just go into

neo-one/packages/neo-one-node-rpc-handler/src/createHandler.ts

Line 55 in 6b4ce55

const RPC_METHODS: { readonly [key: string]: string } = {
with the other RPC_METHODS?

@spencercorwin spencercorwin changed the title [Neo 3.0] Update / Remove RPC commands Update / Remove RPC commands May 22, 2020
@spencercorwin spencercorwin mentioned this issue Aug 27, 2020
Merged
@spencercorwin spencercorwin changed the title Update / Remove RPC commands Update RPC methods/handlers Aug 30, 2020
@spencercorwin spencercorwin added the area/node Categorize issue or PR as node (@neo-one/node) related label Aug 30, 2020
This was referenced Oct 13, 2020
Merged
Merged
@spencercorwin spencercorwin mentioned this issue Nov 3, 2020
Merged
@spencercorwin spencercorwin mentioned this issue Nov 18, 2020
Merged
@spencercorwin
Copy link
Collaborator

Duplicate of #2176

@spencercorwin spencercorwin marked this as a duplicate of #2176 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwbyrne danwbyrne

Labels
area/client Categorize issue or PR as client (@neo-one/client) related area/node Categorize issue or PR as node (@neo-one/node) related priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danwbyrne @spencercorwin