fix(rpc): fix rpc getnep5transfers method for received #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes RPC method
getnep5transfers, which was returning the wrong data forreceived.Also gets closer to the C# input and return formats. Addresses in transfer objects should be base58 addresses instead of hex addresses. And inputs should take a scriptHash or base58 address.
This PR also includes a limit for
getAllStorageRPC method for Native contracts.Test Plan
Was tested manually with Postman to compare against Neo TestNet node results. Will also be tested more thoroughly with unit tests later.
Alternate Designs
None.
Benefits
Closer to Neo3. Fixes bug.
Possible Drawbacks
None.
Applicable Issues
#2009 #1882