-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rush): add appropriate path-mapping, add sourcemaps for dev #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwbyrne
force-pushed
the
rush-sourcemaps
branch
4 times, most recently
from
November 19, 2019 23:14
aa716dd
to
c90a800
Compare
Codecov Report
@@ Coverage Diff @@
## rush #1869 +/- ##
=======================================
Coverage ? 27.48%
=======================================
Files ? 1433
Lines ? 41102
Branches ? 6406
=======================================
Hits ? 11297
Misses ? 29805
Partials ? 0
|
danwbyrne
force-pushed
the
rush-sourcemaps
branch
from
November 19, 2019 23:25
c90a800
to
db0cfe3
Compare
danwbyrne
added a commit
that referenced
this pull request
Nov 19, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 20, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Nov 22, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 2, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 2, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 2, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 3, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 3, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 3, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 3, 2019
fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869)
danwbyrne
added a commit
that referenced
this pull request
Dec 5, 2019
* feat(rush): Migrate to Rush (#1803) (#1871) fix(website): WIP fixing website with Rush (#1814) fixup pouchdb local file loading (#1823) fix(website): WIP to show how to fix website FS (#1822) fix(website): fixup neo-one source file loading into pouchDB (#1825) feat(rush clean): add new rush clean command/script (#1824) feat(rush): prepare rush for npm publishing (#1834) fix(script): fix spencers scripts (#1827) feat(CI): fixup e2e tests (#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (#1850) feat(rush): Add pack/release commands (#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (#1864) fix(rush): refine docker image copies (#1865) fix(rush): revert back to yarn for website (#1868) fix(rush): add/cleanup website prod cmds and compile scripts (#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (#1869) * chore(deps): upgrade dependencies (#1896) * fix(deps): update dependency @types/react to v16.9.14 (#1848) * chore(deps): upgrade dependencies (#1909) * refactor(node3.0): update opcodes & syscalls to match neo3.0 (#1790) * ci(temp remove): turn off CI while 3.x is in a broken state (#1802) * feat(runtime.getnotifications): add notification tracking during vm execution (#1804) Add notification tracking during vm execution for the System.Runtime.GetNotifications syscall #1786 * fix(compiler): update syscalls and opcodes (#1867) * feat(vm): add null stack item, PUSHNULL, ISNULL, and tests (#1873) * feat(vm): add system.blockchain.gettransactionfromblock syscall to vm (#1872) * feat(contractmanifest): add contract manifest models (#1892)
spencercorwin
pushed a commit
to spencercorwin/neo-one
that referenced
this pull request
Jan 31, 2020
* feat(rush): Migrate to Rush (neo-one-suite#1803) (neo-one-suite#1871) fix(website): WIP fixing website with Rush (neo-one-suite#1814) fixup pouchdb local file loading (neo-one-suite#1823) fix(website): WIP to show how to fix website FS (neo-one-suite#1822) fix(website): fixup neo-one source file loading into pouchDB (neo-one-suite#1825) feat(rush clean): add new rush clean command/script (neo-one-suite#1824) feat(rush): prepare rush for npm publishing (neo-one-suite#1834) fix(script): fix spencers scripts (neo-one-suite#1827) feat(CI): fixup e2e tests (neo-one-suite#1833) fix(rush): move smart-contract-lib tests to neo-one-smart-contract-test (neo-one-suite#1850) feat(rush): Add pack/release commands (neo-one-suite#1854) feat(rush): add initial changelog for migration fix(rush): add git hooks back, add tsc command (neo-one-suite#1845) fix(rush): fixup e2e test snapshot pin typescript 3.6.3 temporarily feat(rush): switch to pnpm (neo-one-suite#1864) fix(rush): refine docker image copies (neo-one-suite#1865) fix(rush): revert back to yarn for website (neo-one-suite#1868) fix(rush): add/cleanup website prod cmds and compile scripts (neo-one-suite#1844) fix(rush): add appropriate path-mapping, add sourcemaps for dev (neo-one-suite#1869) * chore(deps): upgrade dependencies (neo-one-suite#1896) * fix(deps): update dependency @types/react to v16.9.14 (neo-one-suite#1848) * chore(deps): upgrade dependencies (neo-one-suite#1909) * refactor(node3.0): update opcodes & syscalls to match neo3.0 (neo-one-suite#1790) * ci(temp remove): turn off CI while 3.x is in a broken state (neo-one-suite#1802) * feat(runtime.getnotifications): add notification tracking during vm execution (neo-one-suite#1804) Add notification tracking during vm execution for the System.Runtime.GetNotifications syscall neo-one-suite#1786 * fix(compiler): update syscalls and opcodes (neo-one-suite#1867) * feat(vm): add null stack item, PUSHNULL, ISNULL, and tests (neo-one-suite#1873) * feat(vm): add system.blockchain.gettransactionfromblock syscall to vm (neo-one-suite#1872) * feat(contractmanifest): add contract manifest models (neo-one-suite#1892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Previously I had just set the
tsconfig
used in every package to use build@neo-one
packages as opposed to including their sources in the compilation (this makes more since with the incremental building we do now).The issue with this is in the dev environment clicking through type definitions brought you to
lib/path/to/types.d.ts
as opposed to where you really want to go to which issrc/path/to/types.ts
.The solution to this is adding the path mapping we used in the lerna version of neo-one
which we were already doing for jest tests since source maps weren't included yet.
To make jest faster and give us proper source-mapping on errors I've added source-mapping to the
buildTypescript
task. These sourcemaps are NOT shipped when usingrush pack
, they are just used in the dev environment and fortunately they "just worked" with jest after they were generated.Test Plan
I tested this by making a test in a package which expected a function imported from another package to not error, and then making that function error. In the old version without sourcemaps we would not get proper stack traces, after implementing source maps all of the stack traces reference source code.
Benefits
Adding sourcemap support for jest decreased total test time from ~350s to ~300s while also providing more information than before.
Our tsconfig structure is a bit confusing, but the basic pattern so far is to have every package use
@neo-one/build-tools/includes/tsconfig.dev.json
and then individual processes such asrush build
orrush test
use their own tsconfig with the@neo-one/*
path removed.