Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neotracker): add neotracker command to neo-one build #1870

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

afragapane
Copy link
Contributor

Description of the Change

Adds neotracker to cli.

  • neo-one start neotracker starts a neotracker instance based on the config
  • neo-one start neotracker --reset resets the database of the neotracker instance
  • neo-one stop neotracker stops the neotracker instance
  • neo-one build starts a neotracker instance (--reset also resets database on the instance)

Test Plan

Tested in e2e tests & tested in an external token project.

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

#1748

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #1870 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
- Coverage   68.64%   68.51%   -0.13%     
==========================================
  Files        1390     1396       +6     
  Lines       40327    40402      +75     
  Branches     6254     6263       +9     
==========================================
  Hits        27681    27681              
- Misses      12646    12721      +75
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#unit 68.51% <0%> (-0.13%) ⬇️
Impacted Files Coverage Δ
...kages/neo-one-cli-common-node/src/configuration.ts 28.98% <ø> (ø) ⬆️
packages/neo-one-cli/src/common/isRunning.ts 0% <0%> (ø)
packages/neo-one-cli/src/utils/index.ts 0% <0%> (ø) ⬆️
packages/neo-one-cli/src/cmd/start/neotracker.ts 0% <0%> (ø)
packages/neo-one-cli/src/build/createTasks.ts 0% <0%> (ø) ⬆️
packages/neo-one-cli/src/cmd/start/index.ts 0% <0%> (ø) ⬆️
packages/neo-one-cli/src/build/startNeotracker.ts 0% <0%> (ø)
packages/neo-one-cli/src/cmd/stop/network.ts 0% <0%> (ø) ⬆️
packages/neo-one-cli/src/cmd/start/network.ts 0% <0%> (ø) ⬆️
packages/neo-one-cli/src/cmd/stop/index.ts 0% <0%> (ø) ⬆️
... and 12 more

Copy link
Collaborator

@spencercorwin spencercorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afragapane afragapane merged commit 9a3e32a into neo-one-suite:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants