Preview4 blockchain changes #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2021
spencercorwin
added a commit
that referenced
this pull request
Feb 4, 2021
* feat(sc): Update SC / Compiler changes to match preview4 changes (#2277) need this in for next PR work * Preview4 blockchain changes (#2284) * feat(vm): remove testMode, fixup vm, various quick fixes from misc updates issue" * feat(blockchain): implement new trigger changes / fixup old storage issue * feat(misc): final preview4 changes (#2290) * feat(node): Update all native contracts for preview4 changes * feat(node): Continue syncing with preview4 changes * feat(misc): final changes to bring us in line with preview4 * fix(misc): update nep5 naming to nep17 * fix(sc): re-organize 'ContractState' to match preview4 * nit(nep17): add note to nep17 implementation to update * fix(bc): fixup headerIndexCache, surprised this didn't come up before Co-authored-by: Daniel Byrne <danwbyrne@gmail.com>
spencercorwin
pushed a commit
to spencercorwin/neo-one
that referenced
this pull request
Feb 4, 2021
* feat(vm): remove testMode, fixup vm, various quick fixes from misc updates issue" * feat(blockchain): implement new trigger changes / fixup old storage issue
spencercorwin
added a commit
that referenced
this pull request
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 3 adds:
implement changes 1 and 2 from #2278
Fixes an old issue in the neo-one/node-vm storage implementation. TL;DR the C# version has the table property it can use for indexing but since we don't have that in JS we "cheat" by just appending the table to the key and seeking off of that. This was an issue when deserializing the key for use in the new GasPerBlockRecords storage lookup in the NEO Native contract and was probably an issue before but since we didn't use the key AFTER seeking like this before it didn't come up.
commits 1-2 add:
fixup issues 1,4,6,9 and 12 from #2276
removes testmode and fixes up some of the various changes made in the VM since preview3 that we will need.
Contract storage will be re-implemented with the management contract in #2273
Will continue to use my local neo project until I'm confident there is nothing else that needs to be changed before releasing the preview4 fork.