Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): fix p2p error and add logging #2489

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

spencercorwin
Copy link
Collaborator

Description of the Change

  • Fixes a simple JS function binding bug that was very difficult to find due to logging P2P errors.
  • Adds a simple log to catch this type of thing more easily in the future.

Test Plan

Continued node sync locally works.

Alternate Designs

The new logging in MessageTransform can and should be better but didn't have time to work that in correctly now and just added a console.log.

Benefits

Node working. And better error logging.

Possible Drawbacks

None.

Applicable Issues

#2480
#2410

@spencercorwin spencercorwin merged commit 286a839 into neo-one-suite:master Jun 21, 2021
@spencercorwin spencercorwin deleted the node-p2p branch June 21, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant