forked from neo-project/neo
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC1 to RC2 Comparison #7
Open
spencercorwin
wants to merge
29
commits into
rc1-untouched
Choose a base branch
from
rc2-untouched
base: rc1-untouched
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* UT Codding Style * dotnet format
* Role event * Add abi and blockNumber * Rename * Update src/neo/SmartContract/Native/RoleManagement.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update requireFlags Co-authored-by: Erik Zhang <erik@neo.org>
…based witness is not found (neo-project#2413)
* add network magic to ContractParametersContext * renew note * change magic to network in json * fix * Change * Change to network * Rename Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Qiao Jin <jinqiao0423@gmail.com>
* Prevent negative GAS * Create handler for System.Runtime.BurnGas Co-authored-by: Erik Zhang <erik@neo.org>
…n inside CalculateNetworkFee method (neo-project#2414) * Update calculate fee * Fix * Update src/neo/Wallets/Wallet.cs Co-authored-by: AnnaShaleva <shaleva.ann@gmail.com> * Fix size * Update src/neo/Wallets/Wallet.cs Co-authored-by: AnnaShaleva <shaleva.ann@gmail.com> * Remove foreach * Or 0 Co-authored-by: AnnaShaleva <shaleva.ann@gmail.com> Co-authored-by: Erik Zhang <erik@neo.org>
* Add more functions to StdLib * Use attributes (neo-project#2424) * Apply suggestions from code review Co-authored-by: Shargon <shargon@gmail.com> * fix * Add UT * Update prices * removeEmptyEntries Co-authored-by: Shargon <shargon@gmail.com>
* Check if the PK it's a valid one * Optimization Co-authored-by: Erik Zhang <erik@neo.org>
* Ensure ExtensiblePayload * Remove check sender Co-authored-by: Erik Zhang <erik@neo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.