Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Script Hash Identification Change #82

Merged
merged 9 commits into from
Dec 9, 2020
Merged

Conversation

devhawk
Copy link
Contributor

@devhawk devhawk commented Dec 7, 2020

This PR adapts neo debugger to changes introduced by neo-project/neo#2044

In particular, this change adds a new IExecutionContext.ScriptIdentifier property. This property represents the script hash identifier generated when a contract is deployed to the blockchain. IExecutionContext.ScriptHash is the SHA 256 hash of the contract binary. Both are needed in neo debugger - the former is how contracts are identified by the contract execution engine and contract state table. The latter is used for mapping contracts to debugger information.

@devhawk devhawk requested review from djnicholson, JohndeVadoss and a team December 8, 2020 21:56
@devhawk devhawk merged commit 1668ac0 into master Dec 9, 2020
@devhawk devhawk deleted the devhawk/no-hash-change branch December 9, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants