Update dev-pack with last neo changes #146

shargon · 2019-12-05T11:42:42Z

Require neo-project/neo-vm#250 neo-project/neo#1331
Issue found neo-project/neo#1330

src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj

tests/Neo.Compiler.MSIL.UnitTests/Neo.Compiler.MSIL.UnitTests.csproj

tests/Neo.SmartContract.Framework.UnitTests/Neo.SmartContract.Framework.UnitTests.csproj

erikzhang · 2019-12-05T12:12:54Z

Need to fix Travis too. Or do we move to Github Actions directly?

shargon · 2019-12-05T12:14:13Z

@erikzhang Please, Could you take a look to neo-project/neo#1330 ?

…Framework.UnitTests.csproj Co-Authored-By: Erik Zhang <erik@neo.org>

…csproj Co-Authored-By: Erik Zhang <erik@neo.org>

Co-Authored-By: Erik Zhang <erik@neo.org>

shargon · 2019-12-05T12:17:24Z

Need to fix Travis too. Or do we move to Github Actions directly?

I think that we should move to github actions directly. What do you prefer?

devhawk · 2019-12-05T19:55:23Z

src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj


  <PropertyGroup>
    <Copyright>2015-2019 The Neo Project</Copyright>
    <AssemblyTitle>Neo.Compiler.MSIL</AssemblyTitle>
    <Version>2.4.1</Version>
    <Authors>The Neo Project</Authors>
-    <TargetFrameworks>netcoreapp2.0;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>netcoreapp3.1;netstandard2.1</TargetFrameworks>


Why are we supporting netstandard2.1 here. This is a CLI tool, it should just have the single 3.1 target framework

So it means that it is a library too.

why do we need it to be a library too?

https://github.com/neo-project/neo-compiler/pull/147#issue-252914432

This was the PR that turned neon into a library at the time. Maybe some developers have such a need. I do not know.

src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj

codecov · 2019-12-06T19:35:26Z

Codecov Report

❗ No coverage uploaded for pull request base (master@d3d00e2). Click here to learn what that means.
The diff coverage is 15.78%.

@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage          ?   40.82%           
=========================================
  Files             ?       42           
  Lines             ?     4561           
  Branches          ?        0           
=========================================
  Hits              ?     1862           
  Misses            ?     2699           
  Partials          ?        0

Impacted Files	Coverage Δ
tests/Neo.Compiler.MSIL.UnitTests/UnitTest1.cs	`0% <ø> (ø)`
.../Neo.Compiler.MSIL.UnitTests/UnitTest_StaticVar.cs	`0% <ø> (ø)`
...ts/Neo.Compiler.MSIL.UnitTests/UnitTest_Appcall.cs	`0% <ø> (ø)`
...sts/Neo.Compiler.MSIL.UnitTests/UnitTest_Switch.cs	`0% <ø> (ø)`
...Compiler.MSIL.UnitTests/UnitTest_AutoEntrypoint.cs	`0% <0%> (ø)`
...SIL.UnitTests/TestClasses/Contract_shift_bigint.cs	`0% <0%> (ø)`
...ests/Neo.Compiler.MSIL.UnitTests/UnitTest_Shift.cs	`0% <0%> (ø)`
...piler.MSIL.UnitTests/TestClasses/Contract_shift.cs	`0% <0%> (ø)`
tests/Neo.Compiler.MSIL.UnitTests/UnitTest_NULL.cs	`0% <0%> (ø)`
...Neo.Compiler.MSIL.UnitTests/Utils/TestDataCache.cs	`32% <100%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d00e2...60de122. Read the comment docs.

shargon · 2019-12-06T19:42:50Z

tests/Neo.Compiler.MSIL.UnitTests/UnitTest_Shift.cs

            var testengine = new TestEngine();
            testengine.AddEntryScript("./TestClasses/Contract_shift.cs");
            testengine.ScriptEntry.DumpNEF();
            var result = testengine.ExecuteTestCaseStandard("testfunc");
+            ApplicationEngine.Notify -= method;
+
+            CollectionAssert.AreEqual(new BigInteger[] { 16, 17179869184, 4, 0 }, list);


@lightszero please take a look this, with int, we have a different result than BigInteger. it's this expected?

There is only BigInteger in NeoVM, so currently it can only be handled like this.

But integer result should be the same, because it should be converted to BigInteger. It's strange

You are right. We should treat the behavior of negative shifts as undefined and disallow it.

shargon added 3 commits December 5, 2019 12:15

Update references

855709b

Update

3646d7f

Clean file

eb53774

erikzhang reviewed Dec 5, 2019

View reviewed changes

shargon and others added 3 commits December 5, 2019 13:14

Update tests/Neo.SmartContract.Framework.UnitTests/Neo.SmartContract.…

29003b9

…Framework.UnitTests.csproj Co-Authored-By: Erik Zhang <erik@neo.org>

Update tests/Neo.Compiler.MSIL.UnitTests/Neo.Compiler.MSIL.UnitTests.…

8fcc2d8

…csproj Co-Authored-By: Erik Zhang <erik@neo.org>

Update src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj

7b91507

Co-Authored-By: Erik Zhang <erik@neo.org>

shargon added 6 commits December 5, 2019 13:44

Add Reference Counter

0c64481

Clean file

bf647c2

Clean files

361f2fd

Fix travis in order to know the error

2655430

Update packages

cc4f58d

Merge branch 'master' into update-neo

c615da7

shargon mentioned this pull request Dec 5, 2019

Update NeoVM nuget neo-project/neo#1331

Merged

Update .travis.yml

e2ed02a

devhawk reviewed Dec 5, 2019

View reviewed changes

src/Neo.Compiler.MSIL/Neo.Compiler.MSIL.csproj Outdated Show resolved Hide resolved

shargon added 2 commits December 6, 2019 20:25

End changes

d631960

dotnet-format

f3a303e

Fix shift UT

a8f875f

shargon commented Dec 6, 2019

View reviewed changes

erikzhang added 3 commits December 9, 2019 10:17

Update version

27a0cc7

Update framework

0b9efb5

Fix UT

3368ebd

erikzhang approved these changes Dec 9, 2019

View reviewed changes

Merge branch 'master' into update-neo

60de122

shargon merged commit ed93668 into neo-project:master Dec 9, 2019

shargon deleted the update-neo branch December 9, 2019 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dev-pack with last neo changes #146

Update dev-pack with last neo changes #146

shargon commented Dec 5, 2019 •

edited

Loading

erikzhang commented Dec 5, 2019 •

edited

Loading

shargon commented Dec 5, 2019

shargon commented Dec 5, 2019 •

edited

Loading

devhawk Dec 5, 2019

erikzhang Dec 6, 2019

devhawk Dec 6, 2019

erikzhang Dec 6, 2019

codecov bot commented Dec 6, 2019 •

edited

Loading

shargon Dec 6, 2019

erikzhang Dec 9, 2019

shargon Dec 9, 2019

erikzhang Dec 9, 2019

Update dev-pack with last neo changes #146

Update dev-pack with last neo changes #146

Conversation

shargon commented Dec 5, 2019 • edited Loading

erikzhang commented Dec 5, 2019 • edited Loading

shargon commented Dec 5, 2019

shargon commented Dec 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 6, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shargon commented Dec 5, 2019 •

edited

Loading

erikzhang commented Dec 5, 2019 •

edited

Loading

shargon commented Dec 5, 2019 •

edited

Loading

codecov bot commented Dec 6, 2019 •

edited

Loading