Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ByteString #376

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Add ByteString #376

merged 3 commits into from
Oct 20, 2020

Conversation

erikzhang
Copy link
Member

No description provided.

@devhawk
Copy link
Contributor

devhawk commented Oct 5, 2020

Can we merge #362 first?

@erikzhang
Copy link
Member Author

Can we merge #362 first?

I will merge it after the alias is reverted.

@devhawk
Copy link
Contributor

devhawk commented Oct 7, 2020

I will merge it after the alias is reverted.

If we revert the alias, it won't compile

@chenzhitong
Copy link
Member

chenzhitong commented Oct 15, 2020 •
edited
Loading

Fixed UT for this PR

#377

@chenzhitong chenzhitong mentioned this pull request Oct 15, 2020
Merged
@erikzhang erikzhang merged commit e3d8da3 into master Oct 20, 2020
@erikzhang erikzhang deleted the ByteString branch October 20, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tommo-L Tommo-L Tommo-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erikzhang @devhawk @chenzhitong @Tommo-L @shargon