Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe Attribute #401

Closed
wants to merge 2 commits into from
Closed

Safe Attribute #401

wants to merge 2 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Dec 5, 2020 •
edited
Loading

Require neo-project/neo#2120 for UT pass
Wait for #391

@shargon shargon mentioned this pull request Dec 5, 2020
Merged
@shargon
Copy link
Member Author

shargon commented Dec 9, 2020

After merge #391 I think that we can merge this one and fix the UT in #402 (update nuget) , What do you think?

@superboyiii
Copy link
Member

superboyiii commented Dec 10, 2020 •
edited
Loading

I test it merged with #391 and #402, it works well.
image
By the way, maybe we should make some method forced to be unsafe such like these including storage write(onPayment, deploy...)
Otherwise it will cause break when running.
image

image

@shargon
Copy link
Member Author

shargon commented Dec 10, 2020

@superboyiii safe should be used wisely :)

@superboyiii
Copy link
Member

@superboyiii safe should be used wisely :)

For me it's OK for Preview4.

@roman-khimov roman-khimov mentioned this pull request Dec 10, 2020
Closed
@shargon
Copy link
Member Author

shargon commented Dec 10, 2020

Will be merged with #402 chenzhitong#6

@shargon
Copy link
Member Author

shargon commented Dec 10, 2020

Closed because it will come with #402

@shargon shargon closed this Dec 10, 2020
@shargon shargon deleted the safe-attribute branch December 10, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shargon @superboyiii