[Framework Add] implement payable #990
Conversation
| onNEP11PaymentMethod.Parameters[0].Type == ContractParameterType.Hash160 && | ||
| onNEP11PaymentMethod.Parameters[1].Type == ContractParameterType.Integer && | ||
| onNEP11PaymentMethod.Parameters[2].Type == ContractParameterType.Any; |
There was a problem hiding this comment.
Parameter names should also be checked, they are a part of the standard. Take a look at https://github.com/nspcc-dev/neo-go/blob/319880e2014ebbe8abd8ce58dcf212869c22604b/pkg/smartcontract/manifest/standard/comply.go#L68.
There was a problem hiding this comment.
This can be very strict, maybe we want to call to our token myTokenId, I think that names are not needed
There was a problem hiding this comment.
@roman-khimov, what do you think?
There was a problem hiding this comment.
I'm thinking of transfer(to Hash160, from Hash160, amount Integer, id ByteString, _ Any) and Comply() preventing it.
...eo.SmartContract.Framework.UnitTests/TestingArtifacts/Contract_SupportedStandard11Payable.cs
Outdated
Show resolved
Hide resolved
tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard11Payable.cs
Outdated
Show resolved
Hide resolved
tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard17Payable.cs
Outdated
Show resolved
Hide resolved
|
Weird, test runs OK on my macos |
Let's wait for merge the proposal |
This pr focus on implement NEP11 and NEP17 callback standards.
Wait for neo-project/proposals#169