Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log plugin #112

Closed
wants to merge 1 commit into from
Closed

Log plugin #112

wants to merge 1 commit into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Aug 2, 2019

@shargon shargon requested a review from erikzhang August 2, 2019 10:08
This was referenced Aug 2, 2019
Closed
Merged
@erikzhang
Copy link
Member

No. We should create a new plugin. "ApplicationLog` is for logging transaction execution results.

@shargon
Copy link
Member Author

shargon commented Aug 2, 2019

Maybe we should rename ApplicationLog, the expected behaviour is for logs 😆

@igormcoelho
Copy link
Contributor

Let's create a new plugin, SystemLog plugin, and use for this. ApplicationLog is less logging and more application data processing itself.

@shargon
Copy link
Member Author

shargon commented Aug 2, 2019

if we decide the name, i can make the changes

@shargon shargon closed this Aug 12, 2019
@shargon shargon deleted the log-plugin branch August 12, 2019 06:22
@shargon shargon mentioned this pull request Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang Awaiting requested review from erikzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shargon @erikzhang @igormcoelho