Fix RpcNep5Tracker for uncollectible chain snapshot & ready for plugin-v2.10.3 release #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
requested changes
Aug 27, 2019
shargon
reviewed
Aug 27, 2019
| @@ -40,7 +41,7 @@ public override void Configure() | |||
| if (_db == null) | |||
| { | |||
| var dbPath = GetConfiguration().GetSection("DBPath").Value ?? "Nep5BalanceData"; | |||
| _db = DB.Open(dbPath, new Options { CreateIfMissing = true }); | |||
| _db = DB.Open(Path.GetFullPath(dbPath), new Options { CreateIfMissing = true }); | |||
There was a problem hiding this comment.
Is this well rebased? i think that this change comes from another PR
There was a problem hiding this comment.
Yes, I sync it from NEO3's PR. When two nodes installed RpcNep5Tracker, they aren't able to run together on the same PC because they're using the same dbPath (relative path). This PR is able to solve this issue . I've tested it on my local.
Delete test mode
Turn extraGAS to 100000000
erikzhang
reviewed
Aug 28, 2019
Remove unused neo2.10.3 nuget
erikzhang
previously approved these changes
Aug 28, 2019
|
I checked with neo3, and this is for neo2, @erikzhang could you revert my last pull? |
This reverts commit 9922d4c.
erikzhang
approved these changes
Aug 28, 2019
|
Reverted. |
shargon
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RpcNep5Tracker for uncollectible chain snapshot & ready for plugin-v2.10.3 release.