Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get message of base exception #463

Merged
merged 3 commits into from
Jan 14, 2021
Merged

get message of base exception #463

merged 3 commits into from
Jan 14, 2021

Conversation

bettybao1209
Copy link
Contributor

@bettybao1209 bettybao1209 commented Jan 13, 2021 •
edited
Loading

fix #458

@bettybao1209 bettybao1209 mentioned this pull request Jan 13, 2021
Closed
chenzhitong
chenzhitong previously approved these changes Jan 14, 2021
View reviewed changes
@chenzhitong
Copy link
Member

And here also need to change

neo-modules/src/ApplicationLogs/LogReader.cs

Lines 166 to 176 in 3fdbcf8

static string GetExceptionMessage(Exception exception)
{
if (exception == null) return null;
if (exception.InnerException != null)
{
return GetExceptionMessage(exception.InnerException);
}
return exception.Message;
}

@shargon shargon merged commit 4b11178 into neo-project:master Jan 14, 2021
@bettybao1209 bettybao1209 deleted the update-exmsg branch January 14, 2021 09:20
joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021
@bettybao1209 @joeqian10
get message of base exception (neo-project#463)
1662646 
* get baseexception message

* update base exception message

* more fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzhitong chenzhitong chenzhitong approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on invokescript with a contract deployment script
3 participants
@bettybao1209 @chenzhitong @shargon