Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Oracle] Optimize neofs return type #554

Merged
merged 12 commits into from
Mar 15, 2021
Merged

[Oracle] Optimize neofs return type #554

merged 12 commits into from
Mar 15, 2021

Conversation

ZhangTao1596
Copy link
Collaborator

@ZhangTao1596 ZhangTao1596 commented Mar 12, 2021 •
edited
Loading

Currently filter can't be applied to neofs results.

Changes:

  • Return string from all neofs reponse.
  • Convert Object to JSON in GetHeaderAsync.

shargon
shargon previously approved these changes Mar 12, 2021
View reviewed changes
This was referenced Mar 12, 2021
Open
Merged
@erikzhang
Copy link
Member

Test?

@superboyiii superboyiii mentioned this pull request Mar 15, 2021
Closed
27 tasks
@ProDog
Copy link
Contributor

ProDog commented Mar 15, 2021

Tested ok.

image

@superboyiii superboyiii merged commit 67cabb8 into neo-project:master Mar 15, 2021
@ZhangTao1596 ZhangTao1596 deleted the fix-neofs-result branch March 15, 2021 10:12
joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021
@ZhangTao1596 @shargon
@erikzhang @superboyiii @joeqian10
[Oracle] Optimize neofs return type (neo-project#554)
792b98d 
* optimize neofs return

* payload to utf8 string

* Change to summary

* Fix some results

* Fix the result of GetHashAsync

* fix header result

* format json

* update neofs-api-csharp

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProDog ProDog ProDog left review comments

@realloc realloc realloc left review comments

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZhangTao1596 @erikzhang @ProDog @realloc @shargon @superboyiii