Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tokens tracker #671

Merged
merged 28 commits into from
Dec 2, 2021
Merged

Conversation

Ashuaidehao
Copy link
Contributor

Close #542 and #651 .

@Ashuaidehao Ashuaidehao mentioned this pull request Nov 4, 2021
src/TokensTracker/Extensions.cs Show resolved Hide resolved
src/TokensTracker/Storage/TokenTransfer.cs Outdated Show resolved Hide resolved
src/TokensTracker/Storage/TokenBalance.cs Outdated Show resolved Hide resolved
src/TokensTracker/Storage/Nep17BalanceKey.cs Outdated Show resolved Hide resolved
src/TokensTracker/Storage/Nep11BalanceKey.cs Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member

I think it should be a single plugin.

@superboyiii
Copy link
Member

I think it should be a single plugin.

It's already a single plugin. No need to combine class of Nep11 and Nep17 together.

@erikzhang
Copy link
Member

Both Nep11Tracker and Nep17Tracker inherit from Plugin. They are two plugin. You need to create a new class for the plugin.

@erikzhang
Copy link
Member

@Ashuaidehao I've added stub classes for you. Please move the methods into the Nep11Tracker and Nep17Tracker classes.

src/Directory.Build.props Outdated Show resolved Hide resolved
superboyiii
superboyiii previously approved these changes Nov 29, 2021
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK. @erikzhang @shargon Ready for final review.

@superboyiii
Copy link
Member

Need your approve. @shargon

@superboyiii superboyiii requested a review from shargon November 30, 2021 07:18
src/TokensTracker/Trackers/NEP-11/Nep11TransferKey.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/NEP-11/Nep11TransferKey.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/NEP-17/Nep17BalanceKey.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/NEP-17/Nep17TransferKey.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/TokenBalance.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/TokenTransfer.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/TokenTransferKey.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/NEP-11/Nep11Tracker.cs Outdated Show resolved Hide resolved
src/TokensTracker/Trackers/TokenTransfer.cs Show resolved Hide resolved
@superboyiii superboyiii merged commit f949f2d into neo-project:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEP-11 tracker
6 participants