Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent DoS with wrong files #81

Merged
merged 10 commits into from
Jul 14, 2019
Merged

Prevent DoS with wrong files #81

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d7181bf
Prevent DoS with wrong files
shargon Apr 15, 2019
24f5757
Constant
shargon Apr 15, 2019
b6f6d84
Merge branch 'master' into small-fix
shargon Apr 16, 2019
85e0282
Throw exception
shargon Apr 19, 2019
95cf355
Merge branch 'master' into small-fix
vncoelho Apr 22, 2019
ac8a763
Merge branch 'master' into small-fix
vncoelho Apr 25, 2019
dba3c9d
Merge branch 'master' into small-fix
shargon May 19, 2019
680c616
Merge branch 'master' into small-fix
vncoelho May 20, 2019
24429f6
Clean
vncoelho May 20, 2019
1e6d100
Merge branch 'master' into small-fix
shargon Jul 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ImportBlocks/BlockImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Akka.Actor;
using Neo.IO;
using Neo.Ledger;
using Neo.Network.P2P;
using Neo.Network.P2P.Payloads;
using System;
using System.Collections.Generic;
Expand Down Expand Up @@ -38,7 +39,11 @@ private static IEnumerable<Block> GetBlocks(Stream stream, bool read_start = fal
if (end <= Blockchain.Singleton.Height) yield break;
for (uint height = start; height <= end; height++)
{
byte[] array = r.ReadBytes(r.ReadInt32());
var size = r.ReadInt32();
if (size > Message.PayloadMaxSize)
throw new ArgumentException($"Block {height} exceeds the maximum allowed size");

byte[] array = r.ReadBytes(size);
if (!CheckMaxOnImportHeight(height)) yield break;
if (height > Blockchain.Singleton.Height)
{
Expand Down