Refac build configs #846
Refac build configs #846
Conversation
|
Why is this pr? |
To prune |
|
Please create an issue or at least describe the problem that you are trying to solve |
|
Behaves the same as description #848 |
|
I will compile here and see results. |
|
Choose #849 or this? They have the same behaviour. |
|
This was first, isn't it? |
Yes |
|
however when you |
src/Directory.Build.props
Outdated
| </Project> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
| <ItemGroup> | ||
| <None Include="config.json" Condition="Exists('config.json') And '$(IncludeSettingsFileOutput)' != 'False'"> |
There was a problem hiding this comment.
We've excluded IncludeSettingsFileOutput from every project, so I think we don't need this condition ('$(IncludeSettingsFileOutput)' != 'False') to be presented here, it's just not relevant anymore.
Is config.json a configuration file of the module's dependent library? If so, then we probably just don't need to copy it while building the module.
There was a problem hiding this comment.
We've excluded
IncludeSettingsFileOutputfrom every project
Not every project, just part of them.
There was a problem hiding this comment.
I mean from every neo-modules project. We don't have any mentions of IncludeSettingsFileOutput=False anymore in neo-modules.
|
@Ashuaidehao this breaks the publish process, please check and fix. |
* 'master' of github.com:neo-project/neo-modules: Fix workflow (neo-project#857) Fix stack exception name (neo-project#855) update workflow (neo-project#856) Refac build configs (neo-project#846) Hotfix for neo-project#850 (neo-project#853) Fix RpcNativeContract (neo-project#851)
Close #848