Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverall in the same way as recent PRs on neo library #882

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho changed the title Fixed coverall in the same way as recent PRs on neo library Fix coverall in the same way as recent PRs on neo library Feb 23, 2024
@vncoelho
Copy link
Member Author

It looks very good now!

@vncoelho
Copy link
Member Author

coverage/coveralls — Coverage increased (+1.1%) to 32.136%

@shargon
Copy link
Member

shargon commented Feb 23, 2024

We need to exclude neo, like in dev-pack

@vncoelho
Copy link
Member Author

We need to exclude neo, like in dev-pack

I do not understand clearly, can you proceed?

@vncoelho
Copy link
Member Author

We need to exclude neo, like in dev-pack

I do not understand clearly, can you proceed?

I see now

| Module                     | Line   | Branch | Method |
+----------------------------+--------+--------+--------+
| Neo.Extensions             | 42.85% | 0%     | 40%    |
+----------------------------+--------+--------+--------+
| Neo.VM                     | 8.56%  | 3.05%  | 17.6%  |
+----------------------------+--------+--------+--------+
| Neo.Cryptography.BLS12_381 | 0%     | 0%     | 0%     |
+----------------------------+--------+--------+--------+
| RpcClient                  | 86.06% | 56.2%  | 91.42% |
+----------------------------+--------+--------+--------+
| Neo.IO                     | 39.4%  | 29.41% | 40.62% |
+----------------------------+--------+--------+--------+
| Neo.Json                   | 35.7%  | 15.33% | 40.46% |
+----------------------------+--------+--------+--------+
| Neo                        | 23.11% | 10.88% | 20.8%  |
+----------------------------+--------+--------+--------+

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@vncoelho
Copy link
Member Author

+---------------+--------+--------+--------+
| Module        | Line   | Branch | Method |
+---------------+--------+--------+--------+
| OracleService | 12.47% | 2.99%  | 3.12%  |
+---------------+--------+--------+--------+
| MPTTrie       | 96.23% | 88.46% | 98.36% |
+---------------+--------+--------+--------+
| LevelDBStore  | 52.55% | 73.33% | 47.43% |
+---------------+--------+--------+--------+
| RocksDBStore  | 53.19% | 43.75% | 50%    |
+---------------+--------+--------+--------+
| RpcServer     | 0%     | 0%     | 0%     |
+---------------+--------+--------+--------+
| RpcClient     | 86.06% | 56.2%  | 91.42% |
+---------------+--------+--------+--------+

+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 50.46% | 39.11% | 58.1%  |
+---------+--------+--------+--------+
| Average | 50.08% | 44.12% | 48.38% |
+---------+--------+--------+--------+

@vncoelho
Copy link
Member Author

coverage/coveralls — Coverage increased (+17.0%) to 48.035%

@vncoelho
Copy link
Member Author

@shargon, this is ready as well

.github/workflows/main.yml Outdated Show resolved Hide resolved
@shargon shargon merged commit 41084dd into master Feb 23, 2024
5 checks passed
@shargon shargon deleted the vncoelho-patch-2 branch February 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants