Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix OnShowPoolCommand after Mempool changes #288

Merged
merged 13 commits into from
Mar 6, 2019
Merged

Conversation

vncoelho
Copy link
Member

No description provided.

@vncoelho vncoelho requested a review from jsolman January 14, 2019 20:25
Copy link
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also want to add a parameter for whether to show only the verified transactions in the pool.

neo-cli/Shell/MainService.cs Outdated Show resolved Hide resolved
jsolman
jsolman previously approved these changes Jan 15, 2019
@jsolman
Copy link
Contributor

jsolman commented Jan 15, 2019

Neo 2.9.5 will need to get released first and get referenced in this project also so that this will have access to the new MemoryPool methods before this can be merged.

@erikzhang
Copy link
Member

You can use MyGet daily build version for testing.

@vncoelho
Copy link
Member Author

I already tested locally, Erik, with https://github.com/NeoResearch/neo-tests/blob/master/docker-build-neo-cli/env-repositories-improved-dbft.sh.
It is working.

However, I got some strange Akka red messages, probably related to the mempool changes, I need to double check.

@jsolman
Copy link
Contributor

jsolman commented Jan 16, 2019

@vncoelho The error you got may have been related to my fix today neo-project/neo/pull/549

Pretty sure that was it. I've merged in the fix now.

@vncoelho
Copy link
Member Author

Perfect, Jeff, I tested here and errors disappeared.

This PR is also correct.
Maybe it is a good time to release 2.9.5, because commit phase will kind of require everyone to update their protocol and the current changes are softer.

@jsolman
Copy link
Contributor

jsolman commented Jan 16, 2019

I agree with releasing 2.9.5 ASAP, since it should help ensure a reliable network.

@vncoelho
Copy link
Member Author

@erikzhang erikzhang merged commit a24cd2d into master Mar 6, 2019
@erikzhang erikzhang deleted the fix-OnShowPoolCommand branch March 6, 2019 05:32
Jim8y pushed a commit to Jim8y/neo-node that referenced this pull request Aug 18, 2021
* refactoring

* message priority

* add failure reason for `sendrawtransaction` (neo-project#116)

* fix bug in `sendrawtransaction`

* improve RpcServer and Plugin system

* add `unconnected` to RPC command `getpeers`

* update dependencies:

- Microsoft.AspNetCore.ResponseCompression v2.1.1
- Microsoft.AspNetCore.Server.Kestrel v2.1.1
- Microsoft.AspNetCore.Server.Kestrel.Https v2.1.1
- Microsoft.EntityFrameworkCore.Sqlite v2.1.1
- Microsoft.Extensions.Configuration.Json v2.1.1

* add WebSocket

* fix bug in Snapshot.Dispose()

* Hides the caught exceptions logs in `RemoteNode`

* fix block stuck

* fix bug in p2p connection

* fix neo-project#305

* fix consensus

* checked on Fixed8 mul

* solve the problem of disconnecting from peers

* fix bug in `System.Runtime.GetTime`

* add RPC command: `getwalletheight`

* fix p2p bug

* Prevent error messages when exiting

* optimize p2p network

* allow user interface to send messages to plugins

* change version to 2.9.0

* backward compatible for sendrawtransaction

* Solve the problem of resynchronizing blocks

* put unverified transactions in the memory pool back into the message queue after the block is persisted

* minor change to consensus
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants