-
Notifications
You must be signed in to change notification settings - Fork 224
Fix OnShowPoolCommand after Mempool changes #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also want to add a parameter for whether to show only the verified transactions in the pool.
Neo 2.9.5 will need to get released first and get referenced in this project also so that this will have access to the new MemoryPool methods before this can be merged. |
You can use MyGet daily build version for testing. |
I already tested locally, Erik, with https://github.com/NeoResearch/neo-tests/blob/master/docker-build-neo-cli/env-repositories-improved-dbft.sh. However, I got some strange Akka red messages, probably related to the mempool changes, I need to double check. |
@vncoelho The error you got may have been related to my fix today neo-project/neo/pull/549 Pretty sure that was it. I've merged in the fix now. |
Perfect, Jeff, I tested here and errors disappeared. This PR is also correct. |
I agree with releasing 2.9.5 ASAP, since it should help ensure a reliable network. |
There is a pre-release here if needed: https://github.com/NeoResearch/neo-tests/blob/master/releases/neo-release-2.9.5-all-plugins-improved-dbft.zip |
* refactoring * message priority * add failure reason for `sendrawtransaction` (neo-project#116) * fix bug in `sendrawtransaction` * improve RpcServer and Plugin system * add `unconnected` to RPC command `getpeers` * update dependencies: - Microsoft.AspNetCore.ResponseCompression v2.1.1 - Microsoft.AspNetCore.Server.Kestrel v2.1.1 - Microsoft.AspNetCore.Server.Kestrel.Https v2.1.1 - Microsoft.EntityFrameworkCore.Sqlite v2.1.1 - Microsoft.Extensions.Configuration.Json v2.1.1 * add WebSocket * fix bug in Snapshot.Dispose() * Hides the caught exceptions logs in `RemoteNode` * fix block stuck * fix bug in p2p connection * fix neo-project#305 * fix consensus * checked on Fixed8 mul * solve the problem of disconnecting from peers * fix bug in `System.Runtime.GetTime` * add RPC command: `getwalletheight` * fix p2p bug * Prevent error messages when exiting * optimize p2p network * allow user interface to send messages to plugins * change version to 2.9.0 * backward compatible for sendrawtransaction * Solve the problem of resynchronizing blocks * put unverified transactions in the memory pool back into the message queue after the block is persisted * minor change to consensus
No description provided.