Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add MaxConnectionsPerAddress to Settings #320

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Add MaxConnectionsPerAddress to Settings #320

merged 3 commits into from
Apr 5, 2019

Conversation

erikzhang
Copy link
Member

Closes #305

vncoelho
vncoelho reviewed Mar 14, 2019
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like travis did not found the nuget, but it looks correct. It can be re-run later.

Maybe a default config can also be added in the .json file for these last 3 variables.

shargon
shargon reviewed Mar 14, 2019
View reviewed changes
Copy link
Member

@shargon shargon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i restarted travis but it failed again...

@shargon shargon mentioned this pull request Mar 14, 2019
Closed
shargon
shargon suggested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@shargon shargon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is because now, WalletIndexer is static

@ixje
Copy link
Contributor

ixje commented Apr 1, 2019

Any updates on this? It's really annoying when working with a privatenet.

@erikzhang
Copy link
Member Author

It will be merged in one or two days.

@ixje
Copy link
Contributor

ixje commented Apr 1, 2019

Thanks!

@shargon
Copy link
Member

shargon commented Apr 1, 2019

Travis still failing

@erikzhang erikzhang marked this pull request as ready for review April 5, 2019 12:33
@erikzhang erikzhang merged commit 39912ed into master Apr 5, 2019
@erikzhang erikzhang deleted the feature/maxConnectionsPerAddress branch April 5, 2019 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vncoelho vncoelho vncoelho left review comments

@shargon shargon shargon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikzhang @ixje @shargon @vncoelho