This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
+328
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Nov 13, 2019
shargon
reviewed
Nov 18, 2019
--- | ||
|
||
**Summary or problem description** | ||
A summary of the problem you want to solve or metric you want to improve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
between the title and the content there are no new lines, or is the preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the preview, don't need to add a new line.
This was referenced May 28, 2020
Closed
Tommo-L
previously approved these changes
May 28, 2020
superboyiii
previously approved these changes
May 28, 2020
@shargon @erikzhang Please have a review. |
shargon
previously approved these changes
May 28, 2020
Delete unnecessary tag
superboyiii
dismissed stale reviews from shargon, Tommo-L, and themself
via
May 29, 2020 06:10
3b78a95
Tommo-L
approved these changes
May 29, 2020
shargon
approved these changes
May 29, 2020
Merge? |
Does this modification fit in this repo? Maybe it's better to move to neo-project/neo. |
Agree, since |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New readme, issue templates and contributing.md