Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

added unconnectedPeers and badPeers to OnShowNodeCommand #5

Closed
wants to merge 8 commits into from
Closed

added unconnectedPeers and badPeers to OnShowNodeCommand #5

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2017

updated to netcoreapp1.1 as the City of Zion unit tests are based on netcoreapp1.1 , so this allows the nuget packages to be used by their neo-cli.

added unconnectedPeers and badPeers to OnShowNodeCommand.

This is useful for debugging the NEO network. For example there was a problem seeing china from chicago, usa on July 31st. I saw the unconnectedPeers node count drop from ~250 to ~70.

dps added 6 commits July 29, 2017 11:54
* MainService.cs: 1. changed prompt from "ant" to "neo".

2 added text to the "help" command to describe block import and
  export.
  line with neo unit tests.

* MainService.cs: added unconnected peers and bad peers to "Show node"
  CLI command
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw an "import blocks" command in help message, but the command is not in the code. Please remove it.

Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why we should include package "NuGet.Build.Tasks.Pack"?

@ghost
Copy link
Author

ghost commented Aug 2, 2017

NuGet.Build.Tasks.Pack is required on VS2017 on OSX to run "create NuGet Package".
otherwise I get the error:
error MSB4057: The target "Pack" does not exist in the project

i run nuget package before running "dotnet publish -c release" because it gives clearer error messages when packages are linked improperly.

@erikzhang
Copy link
Member

Did you try "dotnet restore"?

@erikzhang erikzhang closed this Aug 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant