This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Refactor node commands #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Jan 27, 2020
erikzhang
reviewed
Feb 11, 2020
Co-Authored-By: Erik Zhang <erik@neo.org>
erikzhang
reviewed
Feb 11, 2020
Co-Authored-By: Erik Zhang <erik@neo.org>
vncoelho
reviewed
Feb 11, 2020
eryeer
reviewed
Feb 13, 2020
erikzhang
approved these changes
Mar 19, 2020
I think that |
vncoelho
approved these changes
Mar 19, 2020
Tommo-L
approved these changes
Mar 19, 2020
|
@erikzhang Seems the Git Check stops, could you fix it? |
|
@erikzhang could you merge this PR? |
|
Is it tested? |
Yes, it's tested from my side, we can wait until @superboyiii and @nicolegys approvals. |
|
@shargon @erikzhang From my side, it passed our manual test. We're now trying to use automatic test tools to verify it more seriously. Give me three days to get final result. If it's OK, we could merge this into master then maybe release preview2 at the beginning of next week. |
|
@superboyiii take your time |
|
@shargon @erikzhang Test result shows it works well. |
superboyiii
approved these changes
Mar 26, 2020
Qiao-Jin
added a commit
to Qiao-Jin/neo-node
that referenced
this pull request
Apr 1, 2020
Refactor node commands (neo-project#536)
shargon
pushed a commit
that referenced
this pull request
Apr 17, 2020
shargon
added a commit
that referenced
this pull request
Apr 18, 2020
* Show version in pool * UpdateChnages * adapt Dockerfile to recent code changes (#536) (#567) * Move syscall to native contract * Start oracle * Allow start Oracle * Oracle test * Show version in pool * UpdateChnages * Move syscall to native contract Co-authored-by: Guil. Sperb Machado <gsm@machados.org>
Jim8y
pushed a commit
to Jim8y/neo-node
that referenced
this pull request
Aug 18, 2021
* Add commit phase to consensus algorithm (neo-project#534) * Add commit phase to consensus algorithm * fix tests * Prevent repeated sending of `Commit` messages * RPC call gettransactionheight (neo-project#541) * getrawtransactionheight Nowadays two calls are need to get a transaction height, `getrawtransaction` with `verbose` and then use the `blockhash`. Other option is to use `confirmations`, but it can be misleading. * Minnor fix * Shargon's tip * modified * Allow to use the wallet inside a RPC plugin (neo-project#536) * Clean code * Clean code * Minor fix on mempoolVerified * Add MemoryPool Unit tests. Fix bug on initital start of Persisting the Genesis block. * Prevent `ConsensusService` from receiving messages before starting (neo-project#573) * Prevent `ConsensusService` from receiving messages before starting * fixed tests - calling OnStart now * Consensus recovery log (neo-project#572) * Pass store to `ConsensusService` * Implement `ISerializable` in `ConsensusContext` * Start from recovery log * Fix unit tests due to constructor taking the store. * Add unit tests for serializing and deserializing the consensus context. * Combine `ConsensusContext.ChangeView()` and `ConsensusContext.Reset()` * Add `PreparationHash` field to `PrepareResponse` to prevent replay attacks from malicious primary (neo-project#576) * Fixed a problem where `PrepareResponse.PreparationHash` was not assigned. * Load context from store only when height matches * Recover nodes requesting ChangeView when possible (neo-project#579) * Fixes bug in `OnPrepareRequestReceived()` * Send `RecoveryMessage` only when `message.NewViewNumber <= context.ViewNumber` * Fix and optimize view changing (#590) * Allow to ignore the recovery logs * Add `isRecovering` (neo-project#594) * Fix accepting own prepare request (neo-project#596) * Pick some changes from neo-project#575. * Fixes `Prefixes` * Restore transactions from saved consensus context (neo-project#598) * Refactoring * AggressiveInlining (neo-project#606) * Reset Block reference when consensus context is initialized after block persist. (neo-project#608) * Change `ConsensusPayload` for compatibility (neo-project#609)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the next things: