Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Backup Wallet on change password #578

Merged
merged 6 commits into from
May 7, 2020
Merged

Backup Wallet on change password #578

merged 6 commits into from
May 7, 2020

Conversation

belane
Copy link
Member

@belane belane commented May 3, 2020

Password change (#561) should be harmless but I think it is advisable to make a backup before to avoid losses due to disk corruption, power failures, ...

@superboyiii
Copy link
Member

superboyiii commented May 6, 2020

I've merged neo-project/neo#1627 on my local neo, and tested this PR, it works as expect.

  1. Create a nep6 format wallet and change password, expect [*.bak appears]
  2. Open bak wallet and list related info(pubkey, address)
  3. Rechange password, expect [Wallet backup fail]

Test Result: PASS
image

I'll approve this after neo-project/neo#1627 is merged.

shargon
shargon previously approved these changes May 6, 2020
@shargon shargon self-requested a review May 6, 2020 11:21
@shargon
Copy link
Member

shargon commented May 6, 2020

could you update the nuget?

@superboyiii superboyiii merged commit abc9f2d into neo-project:master May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants