This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Move SystemLog plugin into neo-cli as a native logger with on/off functionalities. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and "log off" commands to neo-cli.
erikzhang
reviewed
May 12, 2020
shargon
reviewed
May 12, 2020
shargon
reviewed
May 12, 2020
superboyiii
reviewed
May 13, 2020
|
@joeqian10 Unhandled exceptions are not recorded in System log. |
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
superboyiii
reviewed
May 13, 2020
superboyiii
approved these changes
May 13, 2020
|
Why merge it so quickly? I haven't finished my review. |
|
Reverted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close 228.