This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Fix invoke command #613
Merged
Fix invoke command #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we only need the sender's balance |
shargon
previously approved these changes
Jun 24, 2020
|
@cloud8little Could you retest your contract: #614 |
cloud8little
previously approved these changes
Jun 24, 2020
|
Test passed. |
erikzhang
reviewed
Jun 24, 2020
neo-cli/CLI/MainService.Contracts.cs
Outdated
| @@ -57,7 +57,7 @@ private void OnInvokeCommand(UInt160 scriptHash, string operation, JArray contra | |||
| { | |||
| using (SnapshotView snapshot = Blockchain.Singleton.GetSnapshot()) | |||
| { | |||
| UInt160[] accounts = CurrentWallet.GetAccounts().Where(p => !p.Lock && !p.WatchOnly).Select(p => p.ScriptHash).Where(p => NativeContract.GAS.BalanceOf(snapshot, p).Sign > 0).ToArray(); | |||
| UInt160[] accounts = CurrentWallet.GetAccounts().Where(p => !p.Lock && !p.WatchOnly).Select(p => p.ScriptHash).ToArray(); | |||
There was a problem hiding this comment.
Can we use CurrentWallet.GetAccount() to avoid this loop?
vncoelho
previously approved these changes
Jun 24, 2020
shargon
previously approved these changes
Jun 24, 2020
added 2 commits
June 30, 2020 09:50
|
|
shargon
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #614 Close neo-project/neo#1735
Don't have to check the balance of cosiginers.
@cloud8little plz, have a check.