This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Sync neo changes #676
Merged
Sync neo changes #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Oct 22, 2020
|
@superboyiii could you test it again? neo-project/neo#1973 |
neo-cli/CLI/MainService.cs
Outdated
| @@ -281,10 +281,11 @@ private byte[] LoadDeploymentScript(string nefFilePath, string manifestFilePath, | |||
|
|
|||
| // Build script | |||
|
|
|||
| scriptHash = file.ScriptHash; | |||
| var fileData = file.ToArray(); | |||
| scriptHash = fileData.ToScriptHash(); | |||
There was a problem hiding this comment.
this scripthash is incorrect.
Merged
Works well on my local within neo-project/neo#2044 and neo-project/neo-devpack-dotnet#391. Test with both native and nep17. @shargon |
|
@shargon Need your review again. It works well on my local. |
shargon
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: neo-project/neo#2044
Close #685
Please dont't merge until related PRs are all merged.