Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

User friendly cli console write system #812

Merged
merged 33 commits into from
Aug 31, 2021
Merged

User friendly cli console write system #812

merged 33 commits into from
Aug 31, 2021

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Aug 14, 2021 •
edited
Loading

Log system has four types of output,

  • WriteLine: Ordinary output (Color White)
  • Info: Information output (Tag Color Cyan)
  • Warning: Warning output (Prefix Tag Warning: Color Yellow)
  • Error: Error output (Prefix Tag Error: Color Red)

1628911332(1)
1628911343(1)
image

@Jim8y Jim8y mentioned this pull request Aug 15, 2021
Closed
@Jim8y Jim8y changed the title User friendly cli console log system User friendly cli console write system Aug 15, 2021
@superboyiii
Copy link
Member

superboyiii commented Aug 17, 2021 •
edited
Loading

I think we can collect all error msgs in a certain file within ErrID and ErrType, and return cli with error msg. It's much more formal and easy to maintain. It can be done in another PR, never mind.

erikzhang
erikzhang reviewed Aug 18, 2021
View reviewed changes
neo-cli/CLI/MainService.Node.cs Outdated Show resolved Hide resolved
neo-cli/CLI/MainService.Wallet.cs Outdated Show resolved Hide resolved
erikzhang
erikzhang previously approved these changes Aug 19, 2021
View reviewed changes
@Jim8y
Copy link
Contributor Author

Jim8y commented Aug 20, 2021

@shargon

shargon
shargon previously approved these changes Aug 21, 2021
View reviewed changes
@Jim8y
Copy link
Contributor Author

Jim8y commented Aug 23, 2021

@superboyiii

shargon
shargon previously approved these changes Aug 25, 2021
View reviewed changes
shargon
shargon previously approved these changes Aug 27, 2021
View reviewed changes
@superboyiii
Copy link
Member

I will test this.

erikzhang
erikzhang previously approved these changes Aug 31, 2021
View reviewed changes
@superboyiii
Copy link
Member

Tested OK

@superboyiii superboyiii merged commit c56c283 into neo-project:master Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@superboyiii superboyiii superboyiii approved these changes

@shargon shargon shargon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jim8y @superboyiii @shargon @erikzhang